Phase2-hgx363M Modify the code to tune the new scintillator code for the V19 version of HGCal

[bsunanda]

PR description:

Modify the code to tune the new scintillator code for the V19 version of HGCal

PR validation:

Use the runTheMatrix test workflows

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Nothing special

[cmsbuild]

cms-bot internal usage

[cmsbuild]

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-47946/44612

Code check has found code style and quality issues which could be resolved by applying following patch(s)

• code-format:
  https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-47946/44612/code-format.patch
  e.g. curl -k https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-47946/44612/code-format.patch | patch -p1
  You can also run scram build code-format to apply code format directly

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-47946/44613

[cmsbuild]

A new Pull Request was created by @bsunanda for master.

It involves the following packages:

• Geometry/HGCalCommonData (upgrade, geometry)
• Geometry/HGCalGeometry (upgrade, geometry)

@Dr15Jones, @Moanwar, @bsunanda, @civanch, @cmsbuild, @kpedro88, @makortel, @mdhildreth, @srimanob, @subirsarkar can you please review it and eventually sign? Thanks.
@fabiocos, @martinamalberti this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

[bsunanda]

@cmsbuild Please test

[bsunanda]

@cmsbuild Please test

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-47946/44614

[cmsbuild]

Pull request #47946 was updated. @Dr15Jones, @Moanwar, @bsunanda, @civanch, @kpedro88, @makortel, @mdhildreth, @srimanob, @subirsarkar can you please check and sign again.

[cmsbuild]

+1

Size: This PR adds an extra 56KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-30aa39/45715/summary.html
COMMIT: fbc4f8e
CMSSW: CMSSW_15_1_X_2025-04-24-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/47946/45715/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially removed 12 lines from the logs
• Reco comparison results: 14607 differences found in the comparisons
• DQMHistoTests: Total files compared: 50
• DQMHistoTests: Total histograms compared: 3913297
• DQMHistoTests: Total failures: 81622
• DQMHistoTests: Total nulls: 47
• DQMHistoTests: Total successes: 3831608
• DQMHistoTests: Total skipped: 20
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
• Checked 215 log files, 184 edm output root files, 50 DQM output files
• TriggerResults: found differences in 6 / 48 workflows

[bsunanda]

+geometry

[bsunanda]

@subirsarkar Please approve this PR

[subirsarkar]

+Upgrade

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @antoniovilela, @rappoccio, @mandrenguyen (and backports should be raised in the release meeting by the corresponding L2)

[mandrenguyen]

+1