refactor: remove all regexes #120
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rudxain
force-pushed
the
rm-regex
branch
2 times, most recently
from
e2bce9a to
4e7299a
Compare
|
I truly don't think this makes the code more readable... There are a lot of tools that help "dissecting" regexes and I think this makes the code more readable. I prefer not to merge it but thanks for the work ! :) |
|
Fair enough. Aside from readability, I wanted to reduce dependencies, as I've seen PRs doing that. I was worried that my "translation" might have bugs 😅, especially considering the weird edge-cases that
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since all of the patterns are
const, I think it might be a good idea to transpile them to Rust