Skip to content

fix: change login copy to say 'log in' #3879

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 10, 2025
Merged

fix: change login copy to say 'log in' #3879

merged 1 commit into from
Jun 10, 2025

Conversation

joseph-sentry
Copy link
Contributor

@joseph-sentry joseph-sentry commented May 29, 2025 •
edited
Loading

probs cuz login isn't a word

@joseph-sentry joseph-sentry requested a review from a team May 29, 2025 21:31
@codecov Codecov
Copy link

codecov bot commented May 29, 2025 •
edited
Loading

Bundle Report

Changes will increase total bundle size by 18 bytes (0.0%) ⬆️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
gazebo-production-system 6.23MB 9 bytes (0.0%) ⬆️
gazebo-production-esm 6.31MB 9 bytes (0.0%) ⬆️

Affected Assets, Files, and Routes:

view changes for bundle: gazebo-production-system

Assets Changed:

Asset Name Size Change Total Size Change (%)
assets/index-legacy.*.js 5 bytes 716.8kB 0.0%
assets/index-legacy.*.js 2 bytes 4.41kB 0.05%
assets/index-legacy.*.js 2 bytes 2.6kB 0.08%

Files in assets/index-legacy.*.js:

  • ./src/layouts/shared/NetworkErrorBoundary/NetworkErrorBoundary.jsx → Total Size: 7.87kB

  • ./src/layouts/Header/components/GuestHeader/GuestHeader.tsx → Total Size: 3.88kB

  • ./src/services/navigation/useNavLinks.ts → Total Size: 21.53kB

Files in assets/index-legacy.*.js:

  • ./src/pages/EnterpriseLandingPage/ProviderCard/ProviderCard.tsx → Total Size: 2.81kB

Files in assets/index-legacy.*.js:

  • ./src/pages/LoginPage/LoginButton.jsx → Total Size: 1.44kB

  • ./src/pages/LoginPage/LoginPage.jsx → Total Size: 1.88kB

view changes for bundle: gazebo-production-esm

Assets Changed:

Asset Name Size Change Total Size Change (%)
assets/index.*.js 5 bytes 639.46kB 0.0%
assets/index.*.js 2 bytes 4.6kB 0.04%
assets/index.*.js 2 bytes 2.52kB 0.08%

Files in assets/index.*.js:

  • ./src/layouts/shared/NetworkErrorBoundary/NetworkErrorBoundary.jsx → Total Size: 7.85kB

  • ./src/services/navigation/useNavLinks.ts → Total Size: 21.51kB

  • ./src/layouts/Header/components/GuestHeader/GuestHeader.tsx → Total Size: 3.88kB

Files in assets/index.*.js:

  • ./src/pages/EnterpriseLandingPage/ProviderCard/ProviderCard.tsx → Total Size: 2.81kB

Files in assets/index.*.js:

  • ./src/pages/LoginPage/LoginButton.jsx → Total Size: 1.44kB

  • ./src/pages/LoginPage/LoginPage.jsx → Total Size: 1.88kB

@ajay-sentry
Copy link
Contributor

@joseph-sentry Gemini would like a word with you
Screenshot 2025-05-29 at 2 34 03 PM

@codecov Codecov
Copy link

codecov bot commented May 29, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.72%. Comparing base (ac06400) to head (ef32852).
Report is 6 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #3879   +/-   ##
=======================================
  Coverage   98.72%   98.72%           
=======================================
  Files         827      827           
  Lines       15029    15029           
  Branches     4304     4304           
=======================================
  Hits        14838    14838           
  Misses        184      184           
  Partials        7        7
Files with missing lines Coverage Δ
...outs/Header/components/GuestHeader/GuestHeader.tsx 100.00% <ø> (ø)
...ared/NetworkErrorBoundary/NetworkErrorBoundary.jsx 100.00% <100.00%> (ø)
...nterpriseLandingPage/ProviderCard/ProviderCard.tsx 96.77% <ø> (ø)
src/pages/LoginPage/LoginButton.jsx 100.00% <ø> (ø)
src/pages/LoginPage/LoginPage.jsx 100.00% <ø> (ø)
src/services/navigation/useNavLinks.ts 99.03% <ø> (ø)
Components Coverage Δ
Assets 100.00% <ø> (ø)
Layouts 99.71% <100.00%> (ø)
Pages 98.28% <ø> (ø)
Services 99.35% <ø> (ø)
Shared 99.11% <ø> (ø)
UI 99.15% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ac06400...ef32852. Read the comment docs.

@codecov-staging
Copy link

codecov-staging bot commented May 29, 2025 •
edited
Loading

Bundle Report

Changes will increase total bundle size by 18 bytes (0.0%) ⬆️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
gazebo-staging-system 6.23MB 9 bytes (0.0%) ⬆️
gazebo-staging-esm 6.31MB 9 bytes (0.0%) ⬆️

Affected Assets, Files, and Routes:

view changes for bundle: gazebo-staging-system

Assets Changed:

Asset Name Size Change Total Size Change (%)
assets/index-legacy.*.js 2 bytes 4.41kB 0.05%
assets/index-legacy.*.js 2 bytes 2.6kB 0.08%
assets/index-legacy.*.js 5 bytes 716.8kB 0.0%

Files in assets/index-legacy.*.js:

  • ./src/pages/EnterpriseLandingPage/ProviderCard/ProviderCard.tsx → Total Size: 2.81kB

Files in assets/index-legacy.*.js:

  • ./src/pages/LoginPage/LoginPage.jsx → Total Size: 1.88kB

  • ./src/pages/LoginPage/LoginButton.jsx → Total Size: 1.44kB

Files in assets/index-legacy.*.js:

  • ./src/layouts/shared/NetworkErrorBoundary/NetworkErrorBoundary.jsx → Total Size: 7.87kB

  • ./src/services/navigation/useNavLinks.ts → Total Size: 21.53kB

  • ./src/layouts/Header/components/GuestHeader/GuestHeader.tsx → Total Size: 3.88kB

view changes for bundle: gazebo-staging-esm

Assets Changed:

Asset Name Size Change Total Size Change (%)
assets/index.*.js 2 bytes 2.52kB 0.08%
assets/index.*.js 5 bytes 639.46kB 0.0%
assets/index.*.js 2 bytes 4.6kB 0.04%

Files in assets/index.*.js:

  • ./src/pages/LoginPage/LoginPage.jsx → Total Size: 1.88kB

  • ./src/pages/LoginPage/LoginButton.jsx → Total Size: 1.44kB

Files in assets/index.*.js:

  • ./src/layouts/shared/NetworkErrorBoundary/NetworkErrorBoundary.jsx → Total Size: 7.85kB

  • ./src/services/navigation/useNavLinks.ts → Total Size: 21.51kB

  • ./src/layouts/Header/components/GuestHeader/GuestHeader.tsx → Total Size: 3.88kB

Files in assets/index.*.js:

  • ./src/pages/EnterpriseLandingPage/ProviderCard/ProviderCard.tsx → Total Size: 2.81kB

@codecov-qa
Copy link

codecov-qa bot commented May 29, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.72%. Comparing base (ac06400) to head (ef32852).
Report is 6 commits behind head on main.

✅ All tests successful. No failed tests found.

@@           Coverage Diff           @@
##             main    #3879   +/-   ##
=======================================
  Coverage   98.72%   98.72%           
=======================================
  Files         827      827           
  Lines       15029    15029           
  Branches     4296     4296           
=======================================
  Hits        14838    14838           
  Misses        184      184           
  Partials        7        7
Files with missing lines Coverage Δ
...outs/Header/components/GuestHeader/GuestHeader.tsx 100.00% <ø> (ø)
...ared/NetworkErrorBoundary/NetworkErrorBoundary.jsx 100.00% <100.00%> (ø)
...nterpriseLandingPage/ProviderCard/ProviderCard.tsx 96.77% <ø> (ø)
src/pages/LoginPage/LoginButton.jsx 100.00% <ø> (ø)
src/pages/LoginPage/LoginPage.jsx 100.00% <ø> (ø)
src/services/navigation/useNavLinks.ts 99.03% <ø> (ø)
Components Coverage Δ
Assets 100.00% <ø> (ø)
Layouts 99.71% <100.00%> (ø)
Pages 98.28% <ø> (ø)
Services 99.35% <ø> (ø)
Shared 99.11% <ø> (ø)
UI 99.15% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ac06400...ef32852. Read the comment docs.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@codecov-notifications
Copy link

codecov-notifications bot commented May 29, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

@@           Coverage Diff           @@
##             main    #3879   +/-   ##
=======================================
  Coverage   98.72%   98.72%           
=======================================
  Files         827      827           
  Lines       15029    15029           
  Branches     4304     4304           
=======================================
  Hits        14838    14838           
  Misses        184      184           
  Partials        7        7
Files with missing lines Coverage Δ
...outs/Header/components/GuestHeader/GuestHeader.tsx 100.00% <ø> (ø)
...ared/NetworkErrorBoundary/NetworkErrorBoundary.jsx 100.00% <100.00%> (ø)
...nterpriseLandingPage/ProviderCard/ProviderCard.tsx 96.77% <ø> (ø)
src/pages/LoginPage/LoginButton.jsx 100.00% <ø> (ø)
src/pages/LoginPage/LoginPage.jsx 100.00% <ø> (ø)
src/services/navigation/useNavLinks.ts 99.03% <ø> (ø)
Components Coverage Δ
Assets 100.00% <ø> (ø)
Layouts 99.71% <100.00%> (ø)
Pages 98.28% <ø> (ø)
Services 99.35% <ø> (ø)
Shared 99.11% <ø> (ø)
UI 99.15% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ac06400...ef32852. Read the comment docs.

@codecov-public-qa Codecov Public QA
Copy link

codecov-public-qa bot commented May 29, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.72%. Comparing base (ac06400) to head (ef32852).
Report is 6 commits behind head on main.

✅ All tests successful. No failed tests found.

@@           Coverage Diff           @@
##             main    #3879   +/-   ##
=======================================
  Coverage   98.72%   98.72%           
=======================================
  Files         827      827           
  Lines       15029    15029           
  Branches     4296     4304    +8     
=======================================
  Hits        14838    14838           
  Misses        184      184           
  Partials        7        7
Files with missing lines Coverage Δ
...outs/Header/components/GuestHeader/GuestHeader.tsx 100.00% <ø> (ø)
...ared/NetworkErrorBoundary/NetworkErrorBoundary.jsx 100.00% <100.00%> (ø)
...nterpriseLandingPage/ProviderCard/ProviderCard.tsx 96.77% <ø> (ø)
src/pages/LoginPage/LoginButton.jsx 100.00% <ø> (ø)
src/pages/LoginPage/LoginPage.jsx 100.00% <ø> (ø)
src/services/navigation/useNavLinks.ts 99.03% <ø> (ø)
Components Coverage Δ
Assets 100.00% <ø> (ø)
Layouts 99.71% <100.00%> (ø)
Pages 98.28% <ø> (ø)
Services 99.35% <ø> (ø)
Shared 99.11% <ø> (ø)
UI 99.15% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ac06400...ef32852. Read the comment docs.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@thomasrockhu-codecov
Copy link
Contributor

Do check the preview deploy though before merging

@codecov-releaser
Copy link
Contributor

✅ Deploy preview for gazebo ready!

Previews expire after 1 month automatically.

Storybook

Commit Created Cloud Enterprise
ef32852 Thu, 29 May 2025 21:36:13 GMT Cloud Enterprise

@joseph-sentry joseph-sentry added this pull request to the merge queue Jun 10, 2025
Merged via the queue into main with commit 4cec586 Jun 10, 2025
64 checks passed
@joseph-sentry joseph-sentry deleted the joseph/login branch June 10, 2025 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thomasrockhu-codecov thomasrockhu-codecov thomasrockhu-codecov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@joseph-sentry @ajay-sentry @thomasrockhu-codecov @codecov-releaser