Skip to content

Commit 2abec05

Browse files
committed
Honda: revert to button enable on Nidec (#23828)
* Honda: revert to button enable on Nidec * fix test * bump panda old-commit-hash: a5d39bd
1 parent 458a427 commit 2abec05

File tree

2 files changed

+6
-2
lines changed

2 files changed

+6
-2
lines changed

selfdrive/test/test_models.py

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@
1414
from selfdrive.car.fingerprints import all_known_cars
1515
from selfdrive.car.car_helpers import interfaces
1616
from selfdrive.car.gm.values import CAR as GM
17-
from selfdrive.car.honda.values import CAR as HONDA
17+
from selfdrive.car.honda.values import CAR as HONDA, HONDA_BOSCH
1818
from selfdrive.car.hyundai.values import CAR as HYUNDAI
1919
from selfdrive.car.toyota.values import CAR as TOYOTA
2020
from selfdrive.test.test_routes import routes, non_tested_cars
@@ -232,6 +232,10 @@ def test_panda_safety_carstate(self):
232232
if self.CP.carFingerprint == TOYOTA.SIENNA and checks['brakePressed'] < 25:
233233
checks['brakePressed'] = 0
234234

235+
# Honda Nidec uses button enable in panda, but pcm enable in openpilot
236+
if self.CP.carName == "honda" and self.CP.carFingerprint not in HONDA_BOSCH and checks['controlsAllowed'] < 25:
237+
checks['controlsAllowed'] = 0
238+
235239
failed_checks = {k: v for k, v in checks.items() if v > 0}
236240
self.assertFalse(len(failed_checks), f"panda safety doesn't agree with openpilot: {failed_checks}")
237241

0 commit comments

Comments
 (0)