Honda Bosch: Cruise faults with radar disabled

[joelspiers15]

Describe the bug

To reproduce:

1. Install e2e_long branch
2. Set the DisableRadar_Allow param to 1
3. Enable OP long (VOACC)
4. Attempt to engage a few times

It would usually fault on the second attempt to engage but not always. If you need more examples other than the route I provided I have a few.

What hardware does this issue affect?

comma three

Which car does this affect?

Honda Accord 2018

Provide a route where the issue occurs

3bac110059677809|2022-04-08--16-44-59--0

openpilot version

45c0ea7

Additional info

No response

[briantran33]

This happened to me as well. I have a 2019 Honda Accord 2019. Comma 3 as well running the latest version of e2e_long.

[redacid95]

Here are the 3 segments from my related issue.

f1055ddb93ff2d3b|2022-04-12--17-30-13--4
f1055ddb93ff2d3b|2022-04-12--17-30-13--5
f1055ddb93ff2d3b|2022-04-12--17-30-13--6

[kjake]

Also happens in a 2017 CR-V.

[redacid95]

Is this going to be fixed before 8.14 release? Does anyone have a recommendation for me to look at to fix this issue? This is an issue in master not just e2e_long to be clear.

[redacid95]

So after the above merge request, there is now some new behavior to report. I can get OP to engage if I pressing on the gas pedal, engage, and then release the gas pedal. Every 2 or so engagements, I get a controls mismatch error while pressing the gas pedal, but then I am able to get it to engage immediately after while still pressing the gas. If I am not pressing the gas when I engage, it immediately cruise faults.

[joelspiers15]

@redacid95 What commit did you get that behavior on? I tried cherry-picking the typo PR into the latest e2e_long and couldn't get any engagements without the mismatch.

[redacid95]

@joelspiers15 this is happening on 0.8.14 not just e2e_long. I am on the latest master with this problem. I haven't tested e2e_long in months. This problem likely lies in something recently changed on Panda. Not sure why you can't get any engagements, but I can barely get it to engage.

[joelspiers15]

@redacid95 Tried on the latest master ( c677c6b ) as well which would show "waiting for controls to start" when I started the car with VOACC enabled. Maybe it's master 4 days ago I should try to get that behavior from.

[redacid95]

@joelspiers15 oh no. Sounds like there might be a new issue happening. I haven't updated in about a week. I haven't used my C3 since this issue has started except to test fixes... VOACC is like the only reason why I use my comma. I hate stock long and hate being on old versions. My fault really on that front haha.

[redacid95]

Can confirm “waiting for controls to start”, and I’m failing to go off-road after turning my car off. Wasn’t like that a week ago. I’ll see if I can find what the cause is or submit an issue.

[redacid95]

Found the controls start issue to be with commit #24311. Unrelated to this issue.