Skip to content

add optional Cloud-init support to Debian VM script #5137

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jun 16, 2025

Conversation

koendiender
Copy link
Contributor

@koendiender koendiender commented Jun 14, 2025

✍️ Description

Edit to the Debian VM script to be able to use the "Generic Cloud" image instead of no cloud to use Cloud-init. The script asks for Cloud-init in the advanced settings. It defaults to no.

🔗 Related PR / Issue

Link: # N/A

✅ Prerequisites (X in brackets)

  • Self-review completed – Code follows project standards.
  • Tested thoroughly – Changes work as expected.
  • No security risks – No hardcoded secrets, unnecessary privilege escalations, or permission issues.

🛠️ Type of Change (X in brackets)

  • 🐞 Bug fix – Resolves an issue without breaking functionality.
  • New feature – Adds new, non-breaking functionality.
  • 💥 Breaking change – Alters existing functionality in a way that may require updates.
  • 🆕 New script – A fully functional and tested script or script set.
  • 🌍 Website update – Changes to website-related JSON files or metadata.
  • 🔧 Refactoring / Code Cleanup – Improves readability or maintainability without changing functionality.
  • 📝 Documentation update – Changes to README, AppName.md, CONTRIBUTING.md, or other docs.

@koendiender koendiender requested review from a team as code owners June 14, 2025 12:51
@github-actions github-actions bot added json update script A change that updates a script website A change to the website labels Jun 14, 2025
@MickLesk
Copy link
Member

And why? What advantages do you see for the average user? Cloud Init requires additional settings and the Debian script (as it is currently), is immediately ready for use and immediately available for the average user at any time directly and without detours

@koendiender
Copy link
Contributor Author

IMO it is way easier to set up a VM with Cloud-init. You can set the login information, network settings and even ssh keys way easier than logging in the VM and setting everything up by hand. It is also not best practice to roll out a VM without a password.

@MickLesk
Copy link
Member

Maybe we should add an read -p before? So the User can choose. Maybe for Ubuntu too? For example, I personally prefer to use the nocloud images rather than the cloud init scripts. It's simply much easier, especially for quick developments or tests

@koendiender
Copy link
Contributor Author

Yeah, letting the user choose would probably be a good idea

@MickLesk
Copy link
Member

Can you prepare the PR for this?

Maybe you can test it in VED (other Repo), or directly here

@koendiender
Copy link
Contributor Author

Sure thing! I will turn this PR into a draft until I'm done

@koendiender koendiender marked this pull request as draft June 14, 2025 14:46
@koendiender
Copy link
Contributor Author

Changed the script to ask for Cloud-init in the advanced settings. Defaults to no

@koendiender koendiender marked this pull request as ready for review June 16, 2025 12:39
@MickLesk MickLesk changed the title Add Cloud-init support to Debian VM script add optional Cloud-init support to Debian VM script Jun 16, 2025
@MickLesk MickLesk merged commit ec8a8b1 into community-scripts:main Jun 16, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature json update script A change that updates a script website A change to the website
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants