Skip to content

[miri] install rust-src component to be able to build the miri sysroot #113

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 28, 2025
Merged

[miri] install rust-src component to be able to build the miri sysroot #113

merged 2 commits into from
May 28, 2025

Conversation

narpfel
Copy link
Contributor

@narpfel narpfel commented May 27, 2025

@narpfel narpfel mentioned this pull request May 27, 2025
Merged
@narpfel narpfel marked this pull request as draft May 27, 2025 20:58
@narpfel
Copy link
Contributor Author

narpfel commented May 27, 2025

It turns out that the entire standard library can be deleted (1d47ec0) because Miri only uses the .rlib files in its own sysroot.

@narpfel narpfel marked this pull request as ready for review May 27, 2025 21:03
mattgodbolt
mattgodbolt approved these changes May 28, 2025
View reviewed changes
Copy link
Member

@mattgodbolt mattgodbolt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks

@mattgodbolt mattgodbolt merged commit c2dfc7e into compiler-explorer:main May 28, 2025
@ojeda ojeda mentioned this pull request May 30, 2025
Open
21 tasks
@narpfel narpfel deleted the rust-miri-install-rust-src branch May 30, 2025 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattgodbolt mattgodbolt mattgodbolt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@narpfel @mattgodbolt