Skip to content

Reduce warnings ci #236

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 18, 2024

Conversation

mcbarton
Copy link
Collaborator

@vgvassilev can you merge this PR? It reduces the warnings outputted by the ci by updating to the latest version of various Github actions.

@mcbarton
Copy link
Collaborator Author

@vgvassilev can you take a look at this PR? The changes are needed due to Githubs move from node 12 to node 16 (don't know exactly what this means). Without these changes the workflow will eventually fail to run. The remaining warnings regarding this issue will be solved in a subsequent PR. Its not clear which is the best strategy to deal with the issue in regards of the Github action nelonoel/[email protected] . This action seems to have been abandoned so won't be updated to fix the issue. Given it simply returns the branch name then its probably just worth replacing with our own action to do this, or integrate this into one of the other actions in the workflow.

@alexander-penev
Copy link
Collaborator

alexander-penev commented Apr 18, 2024

@vgvassilev ... Its not clear which is the best strategy to deal with the issue in regards of the Github action nelonoel/[email protected] . This action seems to have been abandoned so won't be updated to fix the issue. Given it simply returns the branch name then its probably just worth replacing with our own action to do this, or integrate this into one of the other actions in the workflow.

I'm not sure, but this BRANCH_NAME has been out of use for a long time. If it is still needed, perhaps it can be taken from GITHUB_REF, if of course such a variable exists in the environment, similar to what they do in the abandoned action: nelonoel/branch-name

@mcbarton
Copy link
Collaborator Author

@vgvassilev ... Its not clear which is the best strategy to deal with the issue in regards of the Github action nelonoel/[email protected] . This action seems to have been abandoned so won't be updated to fix the issue. Given it simply returns the branch name then its probably just worth replacing with our own action to do this, or integrate this into one of the other actions in the workflow.

I'm not sure, but this BRANCH_NAME has been out of use for a long time. If it is still needed, perhaps it can be taken from GITHUB_REF, if of course such a variable exists in the environment, similar to what they do in the abandoned action: nelonoel/branch-name

I'll perform a run without this action, to see whether we even need it anymore, and if so where.

@mcbarton
Copy link
Collaborator Author

@alexander-penev The workflow ran successfully without the branch-name action. Can you merge this PR?

@alexander-penev alexander-penev merged commit f93e7b6 into compiler-research:main Apr 18, 2024
40 checks passed
@mcbarton mcbarton deleted the reduce-warnings-ci branch May 22, 2024 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants