Skip to content

Fix clang tidy + remove warnings when building #272

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 20 commits into from
May 8, 2024

Conversation

mcbarton
Copy link
Collaborator

@mcbarton mcbarton commented May 7, 2024

@vgvassilev This is the PR to correct the bug introduced in clang tidy workflow in #269, found in vgvassilev/clad#883 . Once it is has been found to work in Clad this can be merged immediately.

@mcbarton mcbarton changed the title Fix install-llvm-action version number so 18.1.3 available Fix clang tidy + remove warnings when building May 7, 2024
Copy link
Contributor

github-actions bot commented May 7, 2024

clang-tidy review says "All clean, LGTM! 👍"

Copy link
Contributor

github-actions bot commented May 7, 2024

clang-tidy review says "All clean, LGTM! 👍"

Copy link

codecov bot commented May 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.45%. Comparing base (f93e7b6) to head (88ddb3e).
Report is 21 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             main     #272       +/-   ##
===========================================
- Coverage   87.65%   75.45%   -12.21%     
===========================================
  Files           4        8        +4     
  Lines        1742     2994     +1252     
===========================================
+ Hits         1527     2259      +732     
- Misses        215      735      +520     
Files Coverage Δ
lib/Interpreter/Compatibility.h 92.17% <ø> (-7.83%) ⬇️
lib/Interpreter/CppInterOp.cpp 82.14% <100.00%> (-5.06%) ⬇️
lib/Interpreter/DynamicLibraryManager.cpp 74.03% <100.00%> (ø)
lib/Interpreter/Paths.cpp 34.69% <100.00%> (ø)

... and 4 files with indirect coverage changes

Files Coverage Δ
lib/Interpreter/Compatibility.h 92.17% <ø> (-7.83%) ⬇️
lib/Interpreter/CppInterOp.cpp 82.14% <100.00%> (-5.06%) ⬇️
lib/Interpreter/DynamicLibraryManager.cpp 74.03% <100.00%> (ø)
lib/Interpreter/Paths.cpp 34.69% <100.00%> (ø)

... and 4 files with indirect coverage changes

@vgvassilev vgvassilev merged commit b6ca3b5 into compiler-research:main May 8, 2024
32 of 37 checks passed
@mcbarton mcbarton deleted the fix-clang-tidy branch May 22, 2024 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants