-
Notifications
You must be signed in to change notification settings - Fork 31
Documentation changes as REPL is set to ON by default #398
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
there's some uncertainty here, do we need to have use_cling=off everywhere ? As in if we say repl is on by default, I am guessing that also implies cling is off by default ? (Is this what we were trying to achieve @vgvassilev ?) |
Yes that was mentioned in this comment as well, we can go ahead and remove all |
Yes |
Yes. We should do that. |
@faze-geek let me know when you've removed all references to use_cling=off and i'll review. |
@mcbarton You can have a look right now. |
a8c8ba1
to
6f30744
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this looks fine to me !
@faze-geek You need to make changes in the recently introduced emscripten build instructions file. |
Will make those changes quick. Thanks ! |
6f30744
to
4322fb6
Compare
Description
Continuation of #360
Type of change
Please tick all options which are relevant.
Checklist