Fix form skip logic

[buckhalt]

Bug fix: Stale data from form submission impacting skip logic

Issue:

Interview navigation functions (moveForward and moveBackward) were using stale values of nextValidStageIndex and previousValidStageIndex due to closures. When these indexes were updated during form submission in the beforeNext handler, the navigation functions weren't receiving the updated values. This resulted in behavior where if form data impacted skip logic, the skip logic wasn't working correctly.

Solution:

• Implemented using useRef to store index values as refs
• Added useEffect hooks to update these refs whenever indexes change
• Modified moveForward and moveBackward to use current ref values for updating session progress and stage instead of closure-captured variables

Other changes:

This investigation also revealed a circular deps issue and duplicate selectors (two duplicate versions of getStageIndex). Fixed this by moving some selectors (getActiveSession, getStageIndex) to a shared file and importing from there.

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
fresco-sandbox	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Apr 9, 2025 8:47am

1 Skipped Deployment

Name	Status	Preview	Comments	Updated (UTC)
barf	⬜️ Ignored (Inspect)	Visit Preview		Apr 9, 2025 8:47am

[Copilot]

Copilot reviewed 8 out of 8 changed files in this pull request and generated no comments.

[jthrilly]

Looks great. Only thing for the future would be to remove some of the unnecessary comments, but nbd.