Skip to content

Remove CMAKE_GENERATOR and win cleanup #4357

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 21, 2023
Merged

Remove CMAKE_GENERATOR and win cleanup #4357

merged 1 commit into from
Apr 21, 2023

Conversation

isuruf
Copy link
Member

@isuruf isuruf commented Apr 20, 2023

CMAKE_GENERATOR was added as a workaround for some azure issue which is gone now.

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

cc @bluescarni

CMAKE_GENERATOR was added as a workaround for some azure issue which is
gone now.
@isuruf isuruf requested a review from a team as a code owner April 20, 2023 06:28
@conda-forge-webservices
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@isuruf
Copy link
Member Author

isuruf commented Apr 20, 2023

@conda-forge/core, this removes some workarounds we had for old bugs in windows images.

@isuruf isuruf merged commit f2e408c into conda-forge:main Apr 21, 2023
@isuruf isuruf deleted the win branch April 21, 2023 02:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants