Skip to content

uv-build 0.7.2 (rattler-build, abi3, shellcheck) #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 16 commits into
base: main
Choose a base branch
from

Conversation

bollwyvl
Copy link

@bollwyvl bollwyvl commented Apr 29, 2025

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

References:

Changes:

  • use rattler-build
  • use abi3 (as per upstream, pip check against python_min and 3.13)
  • use pixi (was getting segfaults with the default?)
  • use shellcheck

@conda-forge-admin
Copy link
Contributor

conda-forge-admin commented Apr 29, 2025

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/recipe.yaml) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipe/recipe.yaml:

  • ℹ️ The recipe is not parsable by parser conda-recipe-manager. The recipe can only be automatically migrated to the new v1 format if it is parseable by conda-recipe-manager.

This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/14764345651. Examine the logs at this URL for more detail.

@bollwyvl bollwyvl marked this pull request as ready for review April 29, 2025 01:17
@bollwyvl bollwyvl requested a review from isuruf as a code owner April 29, 2025 01:17
@bollwyvl
Copy link
Author

@conda-forge/uv-build ready for review!

@bollwyvl bollwyvl changed the title uv 0.6.17 (rattler-build, abi3, shellcheck) uv-build 0.6.17 (rattler-build, abi3, shellcheck) Apr 29, 2025
@bollwyvl bollwyvl changed the title uv-build 0.6.17 (rattler-build, abi3, shellcheck) uv-build 0.7.1 (rattler-build, abi3, shellcheck) Apr 30, 2025
@bollwyvl
Copy link
Author

@conda-forge/uv-build back to ready for review with 0.7.1

Comment on lines +43 to +45
ignore_run_exports:
from_package:
- cross-python_${{ target_platform }}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should get prefix-dev/rattler-build#1592 fixed ASAP

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cool: is there anything to be done here?

- maturin ${{ maturin_version }}
- pip
- python
- python-abi3
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be under a is_abi3 check

@bollwyvl
Copy link
Author

@conda-forge-admin please rerender

@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-webservice.

I tried to rerender for you, but it looks like there was nothing to do.

This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/14760185341. Examine the logs at this URL for more detail.

# only build for the minimal python version
skip: not (match(python, python_min ~ '.*') and is_abi3 == 'true')
python:
version_independent: true
Copy link
Member

@isuruf isuruf Apr 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs to be within a is_abi3 block too

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

trying ${{ is_abi3 }}: didn't seem like the schema likes if in that block?

@bollwyvl bollwyvl changed the title uv-build 0.7.1 (rattler-build, abi3, shellcheck) uv-build 0.7.2 (rattler-build, abi3, shellcheck) May 2, 2025
@bollwyvl
Copy link
Author

bollwyvl commented May 2, 2025

@conda-forge-admin please rerender

@conda-forge-admin
Copy link
Contributor

conda-forge-admin commented May 2, 2025

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipe/recipe.yaml) and found some lint.

Here's what I've got...

For recipe/recipe.yaml:

  • ❌ The is_abi3 variant variable is now a boolean value instead of a string (i.e., 'true' or 'false'). Please change syntax like is_abi3 == 'true' to is_abi3`.

For recipe/recipe.yaml:

  • ℹ️ The recipe is not parsable by parser conda-recipe-manager. The recipe can only be automatically migrated to the new v1 format if it is parseable by conda-recipe-manager.

This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/14796804621. Examine the logs at this URL for more detail.

conda-forge-webservices[bot] and others added 3 commits May 2, 2025 14:06
@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/recipe.yaml) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipe/recipe.yaml:

  • ℹ️ The recipe is not parsable by parser conda-recipe-manager. The recipe can only be automatically migrated to the new v1 format if it is parseable by conda-recipe-manager.

This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/14796817689. Examine the logs at this URL for more detail.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants