Skip to content

Win arm64 #55

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 20 commits into from
May 3, 2023
Merged

Win arm64 #55

merged 20 commits into from
May 3, 2023

Conversation

isuruf
Copy link
Member

@isuruf isuruf commented Apr 23, 2023

We are getting rid of some hacks we had for other platforms

  • ucrt is not used as win-arm64 is supported only for windows>=10 and ucrt DLLs are in the system and the ones in the
    system always takes precedence
  • vs2015_runtime is renamed to vc14_runtime and vs2015_runtime is kept for compatibility in x86
  • added a new vs_win-64=2022 output

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipe:

  • It looks like the 'vs2015_version' output doesn't have any tests.
  • It looks like the 'vc' output doesn't have any tests.

@isuruf
Copy link
Member Author

isuruf commented Apr 23, 2023

cc @conda-forge/core, @conda-forge/staged-recipes, @chenghlee

Copy link
Member

@xhochy xhochy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good!

Copy link

@chenghlee chenghlee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

vs*_runtime -> vc*_runtime naming change make sense to me; the new name is far more descriptive of what's actually in the package. I'll open a ticket to make sure similar changes are made to Anaconda's main channel.

@isuruf
Copy link
Member Author

isuruf commented May 3, 2023

Thanks.

@isuruf isuruf merged commit dc05a6d into conda-forge:main May 3, 2023
@h-vetinari
Copy link
Member

Getting a bunch of clobber warnings, I suspect related to this PR:

ClobberWarning: This transaction has incompatible packages due to a shared path.
  packages: conda-forge/win-64::vc14_runtime-14.34.31931-h5081d32_13, conda-forge/win-64::vs2015_runtime-14.34.31931-h4c5c07a_11
  path: 'library/bin/concrt140.dll'

ClobberWarning: This transaction has incompatible packages due to a shared path.
  packages: conda-forge/win-64::vc14_runtime-14.34.31931-h5081d32_13, conda-forge/win-64::vs2015_runtime-14.34.31931-h4c5c07a_11
  path: 'library/bin/msvcp140.dll'

[and so on]

@h-vetinari
Copy link
Member

Interestingly, it also appears to clobber the package artefacts itself, which would seem to imply that the required libs aren't there anymore when the "environment snapshot" after building is taken, and so conda thinks those libs belong to whatever artefact is being packaged:

ClobberWarning: Conda was asked to clobber an existing path.
  source path: C:\Miniforge\pkgs\vs2015_runtime-14.34.31931-h4c5c07a_11\Library\bin\concrt140.dll
  target path: D:\bld\boost-split_1683161338849\_test_env\Library\bin\concrt140.dll

@h-vetinari
Copy link
Member

h-vetinari commented May 4, 2023

I also see this showing up in the CI on PRs that were merged to main, e.g. here, meaning that this will percolate to our published windows builds very quickly.

@h-vetinari
Copy link
Member

Good news: I think we're not actually repackaging the windows-libs in regular artefacts, which takes off a lot of the pressure.

It seems I misread the way the clobberwarnings are emitted (in two parts).

ClobberWarning: This transaction has incompatible packages due to a shared path.
  packages: conda-forge/win-64::vc14_runtime-14.34.31931-h5081d32_13, conda-forge/win-64::vs2015_runtime-14.34.31931-h4c5c07a_11
  path: 'library/bin/concrt140.dll'

[...]

ClobberWarning: Conda was asked to clobber an existing path.
  source path: C:\Miniforge\pkgs\vs2015_runtime-14.34.31931-h4c5c07a_11\Library\bin\concrt140.dll
  target path: D:\bld\boost-split_1683161338849\_test_env\Library\bin\concrt140.dll  # this one will be adapted to whatever feedstock we're in

@h-vetinari
Copy link
Member

Ah, Isuru has a fix, thanks for the super quick response!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants