-
-
Notifications
You must be signed in to change notification settings - Fork 22
Win arm64 #55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Win arm64 #55
Conversation
This reverts commit 89de51e47567e791c336b30c294cc4557e8f2d3a.
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( I do have some suggestions for making it better though... For recipe:
|
…versions and both in versions in between
cc @conda-forge/core, @conda-forge/staged-recipes, @chenghlee |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
vs*_runtime
-> vc*_runtime
naming change make sense to me; the new name is far more descriptive of what's actually in the package. I'll open a ticket to make sure similar changes are made to Anaconda's main
channel.
Thanks. |
Getting a bunch of clobber warnings, I suspect related to this PR:
|
Interestingly, it also appears to clobber the package artefacts itself, which would seem to imply that the required libs aren't there anymore when the "environment snapshot" after building is taken, and so conda thinks those libs belong to whatever artefact is being packaged:
|
I also see this showing up in the CI on PRs that were merged to main, e.g. here, meaning that this will percolate to our published windows builds very quickly. |
Good news: I think we're not actually repackaging the windows-libs in regular artefacts, which takes off a lot of the pressure. It seems I misread the way the clobberwarnings are emitted (in two parts).
|
Ah, Isuru has a fix, thanks for the super quick response! |
We are getting rid of some hacks we had for other platforms
system always takes precedence
vs2015_runtime
is renamed tovc14_runtime
andvs2015_runtime
is kept for compatibility in x86vs_win-64=2022
output