Skip to content

Drop dmlc static library #237

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-webservice.

I've started rerendering the recipe as instructed in #236.

If I find any needed changes to the recipe, I'll push them to this PR shortly. Thank you for waiting!

Here's a checklist to do before merging.

@conda-forge-admin
Copy link
Contributor Author

conda-forge-admin commented Apr 19, 2025

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipe/meta.yaml:

  • ℹ️ py-xgboost output has some malformed specs:
  • In section host: `libxgboost ==cpu_h_PKG_BUILDNUM
  • In section run: `libxgboost ==cpu_h_PKG_BUILDNUM
    xgboost output has some malformed specs:
  • In section host: `py-xgboost ==cpu_pyh_PKG_BUILDNUM
  • In section run: `py-xgboost ==cpu_pyh_PKG_BUILDNUM
    r-xgboost output has some malformed specs:
  • In section host: `libxgboost ==cpu_h_PKG_BUILDNUM
  • In section run: libxgboost =*=cpu_h*_PKG_BUILDNUM Requirement spec fields should match the syntax name [version [build]]to avoid known issues in conda-build. For example, instead of name =version=build, use name version.* build. There should be no spaces between version operators and versions either: python >= 3.8should bepython >=3.8`.

This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/14548774129. Examine the logs at this URL for more detail.

@conda-forge-admin conda-forge-admin marked this pull request as ready for review April 19, 2025 11:36
@jakirkham jakirkham changed the title MNT: rerender Drop dmlc static library Apr 19, 2025
@jakirkham jakirkham marked this pull request as draft April 19, 2025 11:40
@trivialfis
Copy link

Could you please provide some context about this change?

@trivialfis
Copy link

I think we need some changes in the xgboost upstream CMake files.

@jakirkham
Copy link
Member

More context in issue: #236

Was just pushing some initial thoughts up

Yeah agree a CMake change is likely needed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants