Skip to content

python_version_independent: ignore python from other packages too #5654

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 29, 2025
Merged

python_version_independent: ignore python from other packages too #5654

merged 3 commits into from
Mar 29, 2025

Conversation

isuruf
Copy link
Contributor

@isuruf isuruf commented Mar 25, 2025

Description

Checklist - did you ...

  • Add a file to the news directory (using the template) for the next release's release notes?
  • Add / update necessary tests?
  • Add / update outdated documentation?

We were doing

ignore_run_exports_from:
- python

but we should have been doing both

ignore_run_exports_from:
- python
ignore_run_exports:
- python

@isuruf isuruf requested a review from a team as a code owner March 25, 2025 18:43
@github-project-automation github-project-automation bot moved this to 🆕 New in 🔎 Review Mar 25, 2025
@conda-bot conda-bot added the cla-signed [bot] added once the contributor has signed the CLA label Mar 25, 2025
@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Mar 25, 2025 •
edited
Loading

CodSpeed Performance Report

Merging #5654 will not alter performance

Comparing isuruf:python_version_independent (f9f519c) with main (cca79d1)

Summary

✅ 5 untouched benchmarks

beckermr
beckermr requested changes Mar 28, 2025
View reviewed changes
Copy link
Contributor

@beckermr beckermr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs a news item. Otherwise Lgtm.

@github-project-automation github-project-automation bot moved this from 🆕 New to 🏗️ In Progress in 🔎 Review Mar 28, 2025
@github-project-automation github-project-automation bot moved this from 🏗️ In Progress to ✅ Approved in 🔎 Review Mar 28, 2025
@kenodegard
Copy link
Contributor

The planemo test failure is fixed in #5652

Still stumped by the corrupt package failure

@beckermr beckermr merged commit 594b930 into conda:main Mar 29, 2025
27 of 28 checks passed
@github-project-automation github-project-automation bot moved this from ✅ Approved to 🏁 Done in 🔎 Review Mar 29, 2025
@isuruf
Copy link
Contributor Author

isuruf commented Mar 31, 2025

Shall I backport this to 25.3 branch?

@beckermr
Copy link
Contributor

I'd like to do one more bug fix release on the branch and so yes if you want it out.

isuruf added a commit to isuruf/conda-build that referenced this pull request Mar 31, 2025
@isuruf
[25.3.x] python_version_independent: ignore python from other package…
72006d1 
…s too

Backport of PR conda#5654
kenodegard pushed a commit that referenced this pull request Mar 31, 2025
@isuruf @beckermr
python_version_independent: ignore python from other packages too (#5660
4a7d82e 
)

Backport of PR #5654

---------

Co-authored-by: Matthew R. Becker <[email protected]>
@isuruf isuruf mentioned this pull request Apr 28, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@beckermr beckermr beckermr approved these changes

Assignees
No one assigned
Labels
cla-signed [bot] added once the contributor has signed the CLA
Projects
🔎 Review
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@isuruf @kenodegard @beckermr @conda-bot