Skip to content

Debugging corrupt package failures #5657

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

kenodegard
Copy link
Contributor

Description

Noticing an increase in corrupt package test failures:

Checklist - did you ...

  • Add a file to the news directory (using the template) for the next release's release notes?
  • Add / update necessary tests?
  • Add / update outdated documentation?

@github-project-automation github-project-automation bot moved this to 🆕 New in 🔎 Review Mar 28, 2025
@conda-bot conda-bot added the cla-signed [bot] added once the contributor has signed the CLA label Mar 28, 2025
@kenodegard
Copy link
Contributor Author

great now the failure has vanished from this PR...

@kenodegard kenodegard force-pushed the debug-corrupt-package branch from 85f6bd8 to ad4e5f8 Compare March 28, 2025 17:15
@beckermr
Copy link
Contributor

beckermr commented Mar 28, 2025

So the test jobs marked as "serial" are being run with two pytest-xdist workers. Is that maybe the issue?

@kenodegard
Copy link
Contributor Author

interestingly all of the jobs are now cache hits

@kenodegard
Copy link
Contributor Author

So the test jobs marked as "serial" are being run with two purest-xdist workers. Is that maybe the issue?

yeah that's been the case for a while now: #5078

I'd be surprised if that's the reason, plus we're seeing failures on both the "parallel" (tests/cli/test_main_build.py::test_slash_in_recipe_arg_keeps_build_id) and the "serial" (tests/test_api_build.py::test_recipe_builds[relative_url_download]) jobs

@beckermr
Copy link
Contributor

Maybe add some retry test markers to have the test suite try twice as a stopgap?

@kenodegard
Copy link
Contributor Author

kenodegard commented Mar 28, 2025

We could add the retry but I don't understand how effective that would be since the corrupt package is in the cache (/home/runner/conda_pkgs_dir/) so a rerun would just reuse the corrupt package?

@beckermr
Copy link
Contributor

Hrmmm. Can we try things actually in serial as a test?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed [bot] added once the contributor has signed the CLA
Projects
Status: 🆕 New
Development

Successfully merging this pull request may close these issues.

3 participants