Refactor/faithfulness template protocol #1462
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
sergeyklay
suggested changes
Mar 24, 2025
| return f"""Based on the given text, please extract a comprehensive list of FACTUAL, undisputed truths, that can inferred from the provided text. | ||
| These truths, MUST BE COHERENT, and CANNOT be taken out of context. | ||
|
|
||
| Example: | ||
| Example Text: | ||
| Example Text: q |
There was a problem hiding this comment.
Yes, it's a typo thank you for pointing it out!
| ... | ||
|
|
||
| @staticmethod | ||
| def generate_reason(score: float, contradictions: List[str]) -> str: |
There was a problem hiding this comment.
Yes， I just updated it
|
I just opened a PR with an example using Protocol. I believe this approach is more flexible than ABC and makes it much easier for users to define domain-specific evaluation prompt templates. The example has been tested locally with GPT-3.5, and I’ve also fixed the bugs from my previous PR (#1462) everything is working now. Would love your feedback on whether this direction makes sense for DeepEval. |
|
fixed typo, and added "..." |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Title:
Refactor prompt template into protocol for customizable faithfulness evaluation
Description:
This PR extracts the faithfulness prompt logic into a protocol interface (FaithfulnessTemplateProtocol) to allow easy injection of custom prompt templates. This improves flexibility, code clarity, and enables user-defined behavior.