Updating prefix formats #260
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think I'm fine with this, though it is a "breaking" change since it's more restrictive than what was there before. Is this something that we should target for the v0.4 milestone? |
|
Is there currently a planned date for the v0.4 cut? |
|
@saad-ali also suggested a change, removing the "reverse" from "reverse domain name notation" |
|
Will add that to the PR |
…wed; Changed reverse domain name notation to forward domain name notation.
|
Updated. In the recommended domain name format there is no underscore. Do we want to keep it? |
|
Any guidance on how to fix the Travis failure? The protoc versions match between Travis and my local machine (3.5.1) and protobuf versions for protoc-gen-go also match (1.2.0) |
|
LGTM |
|
Updated, PTAL! |
|
Closes #280 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes explicit the implicit restriction that underscores "_" are not allowed in the prefix format, as described in the wiki link. It also proposes to further restrict prefixes to lower-case letters only. Internally in k8s, topology is represented by labels, which unfortunately doesn't allow either underscores or capitalized letters.
This should be a fairly low-risk change, but definitely still worth broadcasting in the next spec release.