Rename volume attributes, publish_info, and id
#318
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saad-ali
commented
Nov 9, 2018
csi.proto
Outdated
| @@ -351,15 +351,22 @@ message Volume { | |||
| // subsequent calls to refer to the provisioned volume. | |||
| string id = 2; | |||
There was a problem hiding this comment.
Feedback from @jieyu @julian-hj: change id to volume_id.
saad-ali
force-pushed
the
renameVolumeAttributes
branch
from
4e17bf0 to
05ff00f
Compare
|
@jieyu @julian-hj Feedback addressed. PTAL |
|
Added fix for #300 in this PR as an additional commit since it was touching the same lines. |
saad-ali
changed the title
attributes, publish_info, and id
jieyu
approved these changes
Nov 12, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #279