Add linter to Canary and fix go 1.23 linting issues #3321
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apostasie
force-pushed
the
b-dev-3320-canary-lint
branch
4 times, most recently
from
fbacb7b to
f56bb72
Compare
AkihiroSuda
reviewed
Aug 17, 2024
AkihiroSuda
reviewed
Aug 17, 2024
apostasie
force-pushed
the
b-dev-3320-canary-lint
branch
from
f56bb72 to
d712613
Compare
|
Thanks, in the commit message could you mention the fixed errors such as The commits can be also split for the each of the SA%d fixes. |
IIUC this is the matter of golangci-lint rather than go itself? |
apostasie
force-pushed
the
b-dev-3320-canary-lint
branch
2 times, most recently
from
c6b9ba3 to
7999201
Compare
I think it is a combination of both? (eg: golangci-lint with that version of go) Anyhow, thanks for the comments. Will integrate all and split in different commits. Right now struggling with windows (as usual), will re-request review when done. |
apostasie
force-pushed
the
b-dev-3320-canary-lint
branch
from
7999201 to
cc7d341
Compare
Signed-off-by: apostasie <[email protected]>
apostasie
force-pushed
the
b-dev-3320-canary-lint
branch
from
cc7d341 to
fd0f954
Compare
Signed-off-by: apostasie <[email protected]>
Signed-off-by: apostasie <[email protected]>
apostasie
force-pushed
the
b-dev-3320-canary-lint
branch
from
51a6e9d to
068866e
Compare
Signed-off-by: apostasie <[email protected]>
|
@AkihiroSuda canary lint is green. All comments addressed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a lint validation to the Canary target.
Currently done on windows (because of the go install on the host), but will move to an independent stage after cleaning up the go_version detection routine.
Once green, we should merge ASAP to help with #3320