-
Notifications
You must be signed in to change notification settings - Fork 659
fix: logs updated on starting of a stopped container #3896
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
49019a2
to
ccb179d
Compare
@AkihiroSuda |
ccb179d
to
e8fb6c4
Compare
@Shubhranshu153 I just have a batch of nits on the test. Btw, feedback on the test framework is highly welcome. Ideally, if we get #3591 in first, we can get rid of the added DelayOnceReaders here (and unbuffer). But anyhow, don't sweat it - I can clean that up afterwards if needed. |
df70bc7
to
72193e6
Compare
Needs rebase |
2c39201
to
65616d7
Compare
9b25406
to
8a8f662
Compare
Signed-off-by: Shubharanshu Mahapatra <[email protected]>
8a8f662
to
2c91198
Compare
this seems like an error regarding go mod jail? Not sure why go.mod is read during runtime. |
It is (AkihiroSuda/gomodjail#50). Gomodjail errors can be ignored for now. |
Rerunning the test for flaky test. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks
Issue:
When we start a container that was running and stopped or exited, logs are not updated.
Steps to Reproduce:
step 1: Run and exit container
fix:
The pr fixes it by adding multiwriters to start of containers.
Interactive Flag Added to start
Nerdctl didn't support interactive flag so added the flag to have compatible behavior with docker