-
Notifications
You must be signed in to change notification settings - Fork 654
[fix] Avoid console SetRaw #4054
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
First failure is unrelated (#4046) |
Signed-off-by: apostasie <[email protected]>
Note: this is blocking #4040. |
I would really like to know why does containerd/console force OPOST. @AkihiroSuda any idea? |
Note: that looks like the second strike for containerd/console (the first one, we had to fork out console.GetCurrent because it is panicking instead of returning an error). Now avoiding their SetRaw method, the only thing that is left in there is 2 calls for termios (tcget / tcset) and an outdated go.mod... I just don't see the value anymore. Suggesting we remove the dependency entirely. |
"github.com/containerd/containerd/v2/core/runtime/v2/logging" | ||
"github.com/containerd/errdefs" | ||
"github.com/containerd/log" | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is an effect of the move to golangciv2.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, can we have a test?
Yes. Let me look into this soon once the dust settles with all the PRs. |
Actually, we already have a test - albeit an indirect one.
When using icmd, icmd exec will replace the command Stdout with an io.Multiwriter. When moving to our new Command implementation, Stdout will be properly set to the pty, which will make |
Fix #4053