Bump up buildg to v0.5.2 and extend startup timeout #4162
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ktock
force-pushed
the
buildg-v0.5
branch
2 times, most recently
from
aaeca3a to
2b582a3
Compare
Signed-off-by: Kohei Tokunaga <[email protected]>
ktock
changed the title
|
Failed tests don't seem to be related to buildg changes. |
apostasie
reviewed
Apr 25, 2025
cmd/nerdctl/builder/builder.go
Outdated
| @@ -146,6 +147,7 @@ func debugCommand() *cobra.Command { | |||
| cmd.Flags().String("image", "", "Image to use for debugging stage") | |||
| cmd.Flags().StringArray("ssh", nil, "Allow forwarding SSH agent to the build. Format: default|<id>[=<socket>|<key>[,<key>]]") | |||
| cmd.Flags().StringArray("secret", nil, "Expose secret value to the build. Format: id=secretname,src=filepath") | |||
| helpers.AddDurationFlag(cmd, "startup-timeout", nil, 1*time.Minute, "", "Timeout for starting up buildg") | |||
There was a problem hiding this comment.
Thanks a lot for this @ktock
Hopefully will resolve our issue here.
Wondering if we need to surface the flag to the nerdctl end-user though?
AkihiroSuda
reviewed
Apr 26, 2025
cmd/nerdctl/builder/builder.go
Outdated
| @@ -146,6 +147,7 @@ func debugCommand() *cobra.Command { | |||
| cmd.Flags().String("image", "", "Image to use for debugging stage") | |||
| cmd.Flags().StringArray("ssh", nil, "Allow forwarding SSH agent to the build. Format: default|<id>[=<socket>|<key>[,<key>]]") | |||
| cmd.Flags().StringArray("secret", nil, "Expose secret value to the build. Format: id=secretname,src=filepath") | |||
| helpers.AddDurationFlag(cmd, "startup-timeout", nil, 1*time.Minute, "", "Timeout for starting up buildg") | |||
There was a problem hiding this comment.
Suggested change
| helpers.AddDurationFlag(cmd, "startup-timeout", nil, 1*time.Minute, "", "Timeout for starting up buildg") | |
| helpers.AddDurationFlag(cmd, "buildg-startup-timeout", nil, 1*time.Minute, "", "Timeout for starting up buildg") |
AkihiroSuda
reviewed
Apr 26, 2025
cmd/nerdctl/builder/builder.go
Outdated
| @@ -167,6 +169,12 @@ func debugAction(cmd *cobra.Command, args []string) error { | |||
| buildgArgs = append([]string{"--debug"}, buildgArgs...) | |||
| } | |||
|
|
|||
| startupTimeout, err := cmd.Flags().GetDuration("startup-timeout") | |||
There was a problem hiding this comment.
Out of the sync with the flag definition
This also extends buildg's default timeout value to 1m Signed-off-by: Kohei Tokunaga <[email protected]>
djdongjin
reviewed
Apr 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to ktock/buildg#242 and #4046