-
Notifications
You must be signed in to change notification settings - Fork 825
CI: give the rootless test user some supplemental groups #6227
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: nalind The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
a984965
to
ba29652
Compare
Exercise preservation of supplemental groups in the tests that use `buildah build` and `buildah from` with `--group-add keep-groups`. Signed-off-by: Nalin Dahyabhai <[email protected]>
ba29652
to
9ecc98e
Compare
@nalind does a test need tweaking?
|
LGTM |
That's a flake we've been seeing since we started testing with runc. The thing that confuses me is that this should be helping us trigger the problem that #6226 aims to fix, but either I'm doing it wrong, or the test isn't noticing the problem. |
What type of PR is this?
/kind other
What this PR does / why we need it:
Exercise preservation of supplemental groups in the tests that use
buildah build
andbuildah from
with--group-add keep-groups
.How to verify it
This should exercise more of the tests we have.
Which issue(s) this PR fixes:
None
Special notes for your reviewer:
Does this PR introduce a user-facing change?