Skip to content

CI: give the rootless test user some supplemental groups #6227

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

nalind
Copy link
Member

@nalind nalind commented Jun 12, 2025

What type of PR is this?

/kind other

What this PR does / why we need it:

Exercise preservation of supplemental groups in the tests that use buildah build and buildah from with --group-add keep-groups.

How to verify it

This should exercise more of the tests we have.

Which issue(s) this PR fixes:

None

Special notes for your reviewer:

Does this PR introduce a user-facing change?

None

Copy link
Contributor

openshift-ci bot commented Jun 12, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nalind

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@nalind nalind force-pushed the ci-rootless-supplemental-group branch from a984965 to ba29652 Compare June 12, 2025 15:09
Exercise preservation of supplemental groups in the tests that use
`buildah build` and `buildah from` with `--group-add keep-groups`.

Signed-off-by: Nalin Dahyabhai <[email protected]>
@nalind nalind force-pushed the ci-rootless-supplemental-group branch from ba29652 to 9ecc98e Compare June 13, 2025 14:32
@TomSweeneyRedHat
Copy link
Member

@nalind does a test need tweaking?

 ok 822 run-exit-status on non executable
[+0647s] not ok 823 Verify /run/.containerenv exist
[+0647s] # (from function `assert' in file ./helpers.bash, line 537,
[+0647s] #  from function `expect_output' in file ./helpers.bash, line 564,
[+0647s] #  in test file ./run.bats, line 621)
[+0647s] #   `expect_output "alpine-working-container"' failed
[+0647s] # /var/tmp/go/src/github.com/containers/buildah/tests /var/tmp/go/src/github.com/containers/buildah/tests
[+0647s] # # [checking for: docker.io/library/alpine]
[+0647s] # # [restoring from cache: /tmp/bats-run-CvOu1h/suite/buildah-image-cache / docker.io/library/alpine]
[+0647s] # Getting image source signatures
[+0647s] # Copying blob sha256:9d16cba9fb961d1aafec9542f2bf7cb64acfc55245f9e4eb5abecd4cdc38d749
[+0647s] # Copying config sha256:961769676411f082461f9ef46626dd7a2d1e2b2a38e6a44364bcbecf51e66dd4
[+0647s] # Writing manifest to image destination
[+0647s] # # /var/tmp/go/src/github.com/containers/buildah/tests/./../bin/buildah from --quiet --pull=false --signature-policy /var/tmp/go/src/github.com/containers/buildah/tests/./policy.json alpine
[+0647s] # alpine-working-container
[+0647s] # # /var/tmp/go/src/github.com/containers/buildah/tests/./../bin/buildah run alpine-working-container ls -1 /run/.containerenv
[+0647s] # /run/.containerenv
[+0647s] # # /var/tmp/go/src/github.com/containers/buildah/tests/./../bin/buildah run alpine-working-container sh -c . /run/.containerenv; echo $engine
[+0647s] # buildah-1.41.0-dev
[+0647s] # # /var/tmp/go/src/github.com/containers/buildah/tests/./../bin/buildah run alpine-working-container sh -c . /run/.containerenv; echo $name
[+0647s] # alpine-working-container
[+0647s] # time="2025-06-13T09:47:28-05:00" level=error msg="seek /sys/fs/cgroup/system.slice/runc-buildah-buildah1965336133.scope/cgroup.freeze: no such device"
[+0647s] # #/vvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvv
[+0647s] # #|     FAIL: buildah run alpine-working-container sh -c . /run/.containerenv; echo $name
[+0647s] # #| expected: 'alpine-working-container'
[+0647s] # #|   actual: 'alpine-working-container'
[+0647s] # #|         > 'time="2025-06-13T09:47:28-05:00" level=error msg="seek /sys/fs/cgroup/system.slice/runc-buildah-buildah1965336133.scope/cgroup.freeze: no such device"'
[+0647s] # #\^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

@TomSweeneyRedHat
Copy link
Member

LGTM
A test is tweaking out, I'm not sure that it's a flake, but I'm not sure it isn't.

@nalind
Copy link
Member Author

nalind commented Jun 13, 2025

That's a flake we've been seeing since we started testing with runc. The thing that confuses me is that this should be helping us trigger the problem that #6226 aims to fix, but either I'm doing it wrong, or the test isn't noticing the problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants