Add support for using hyphens for name separation #1241
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uosis
force-pushed
the
name-separator
branch
3 times, most recently
from
e361859 to
6521958
Compare
p12tic
approved these changes
Jun 13, 2025
There was a problem hiding this comment.
LGTM, thanks.
Please squash fixup commits into what they fix. I think [cleanup bool parsing](https://github.com/containers/podman-compose/pull/1241/commits/cc54f8c6aede6cc2b049bbbd8d5428eacda95975) commit should remain separate because it adjusts unrelated thing and has separate regression potential. No problem if it stays in this PR.
Also please add Signed-off-by line to all your commits as explained in https://github.com/containers/podman-compose/pull/1241/checks?check_run_id=44055914802. Unfortunately we have to do so for each commit.
Signed-off-by: Uosis <[email protected]>
Signed-off-by: Uosis <[email protected]>
|
@p12tic squashed and sign off added. |
p12tic
approved these changes
Jun 15, 2025
|
Thanks a lot! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Second part split from #1236.
Completes #1080 and fixes #1230. Controlled by new name_separator_compat x-podman setting.