Skip to content

Fix Config.yaml schema registration #5851

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 1, 2025
Merged

Fix Config.yaml schema registration #5851

merged 2 commits into from
Jun 1, 2025
+23 −11

Conversation

RomneyDa
Copy link
Collaborator

Fixes #5545

Before, would only update once and extensionUri.fsPath changed, making schema out of date.

This re-registers with new extension versions and also handles case of YAML extension not being installed

@RomneyDa RomneyDa requested a review from a team as a code owner May 26, 2025 21:51
@RomneyDa RomneyDa requested review from sestinj and removed request for a team May 26, 2025 21:51
@cubic-dev-ai cubic-dev-ai
Copy link

cubic-dev-ai bot commented May 26, 2025

Your cubic subscription is currently inactive. Please reactivate your subscription to receive AI reviews and use cubic.

@dosubot dosubot bot added the size:M This PR changes 30-99 lines, ignoring generated files. label May 26, 2025
@netlify Netlify
Copy link

netlify bot commented May 26, 2025 •
edited
Loading

✅ Deploy Preview for continuedev canceled.

Name Link
🔨 Latest commit dfab1ba
🔍 Latest deploy log https://app.netlify.com/projects/continuedev/deploys/6834e24f07c7ef00083edad6

@RomneyDa RomneyDa mentioned this pull request May 26, 2025
Closed
3 tasks
sestinj
sestinj approved these changes Jun 1, 2025
View reviewed changes
Copy link
Contributor

@sestinj sestinj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Seems fair not to add any tests here, it's already going to catch anything and is a strict improvement

@github-project-automation github-project-automation bot moved this from Todo to In Progress in Issues and PRs Jun 1, 2025
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jun 1, 2025
@sestinj sestinj merged commit 938239d into main Jun 1, 2025
36 checks passed
@sestinj sestinj deleted the dallin/always-configure-yaml-schema branch June 1, 2025 05:26
@github-project-automation github-project-automation bot moved this from In Progress to Done in Issues and PRs Jun 1, 2025
@github-actions github-actions bot locked and limited conversation to collaborators Jun 1, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sestinj sestinj sestinj approved these changes

Assignees
No one assigned
Labels
lgtm This PR has been approved by a maintainer size:M This PR changes 30-99 lines, ignoring generated files.
Projects
Issues and PRs
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

config.yaml not finding schema
2 participants
@RomneyDa @sestinj