-
Notifications
You must be signed in to change notification settings - Fork 3.1k
refactor: ♻️ Refactor CodeBaseIndexer out of core #5894
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: ♻️ Refactor CodeBaseIndexer out of core #5894
Conversation
Your cubic subscription is currently inactive. Please reactivate your subscription to receive AI reviews and use cubic. |
✅ Deploy Preview for continuedev canceled.
|
@Patrick-Erichsen related to #5564 I've performed a refactor of CodeBaseIndxer.ts and core.ts to refactor the indexing functions out of core. I'm going to note a few questions in a self review for you. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a great cleanup, will make the callTools
logic we originally discussed less dependent on core
and this is just a solid cleanup in general. Nice we we can remove the awkward codebaseIndexerResolve
things.
Going to wait to merge until I double check with @sestinj on that one comment but otherwise good to go 🚀
f5d7f91
to
f6d114d
Compare
All good to go from me except I think we should just completely remove |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
all looks great. as we're removing the continueServerClient, let's take out the "continue.giveAutocompleteFeedback"
command in VS Code
Waiting on #5937 to merge to fix CD/CI issues. |
905828e
to
764d136
Compare
@Patrick-Erichsen and @sestinj looks like we have 🟢 lights. Could you please review at your convienence? 🙇 |
Description
Refector CodeBaseIndexer out of core.ts in a way that it can be independently passed to tools which might need to perform reindexing. Not in #5564 we would now pass core (this.codeBaseIndexer) to the tools implementations rather than the the entire core object.
Checklist
Screenshots
[ For visual changes, include screenshots. Screen recordings are particularly helpful, and appreciated! ]
Tests
I've manually tested the following in debug:
I've added new tests for CodeBaseIndexer.ts to cover the changes.