You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
#5694 was intended to make apply cancelable but only worked for jetbrains because of how it was set up.
This PR fixes for VS Code
It also passes abort controllers to slash commands to make them cancelable as well.
@RomneyDa thank you for all your amazing work on solving for being able to cancel various pieces of the experience. I closed my cancel button fix. Noting that my only remaining issue appears to be cancelling "thinking/reasoning" and ending up with unmatched messages in the history.
The reason will be displayed to describe this comment to others. Learn more.
I know most of this is just passing around abortController / signal, but at least some part of this should get locked down with a test. otherwise just feels like setting up for whack-a-mole
The reason will be displayed to describe this comment to others. Learn more.
I think this would be a quick and high-value thing to test. There's already a setup for the Chat.tsx component in vitest I think, and would just want to spy on ideMessenger to make sure that it calls post("rejectDiff", ...).
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
lgtmThis PR has been approved by a maintainersize:LThis PR changes 100-499 lines, ignoring generated files.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
dosubot
bot
added
the
size:M
![recurseml[bot]](https://avatars.githubusercontent.com/in/1054195?s=60&v=4){kind=small}
#5694 was intended to make apply cancelable but only worked for jetbrains because of how it was set up.
This PR fixes for VS Code
It also passes abort controllers to slash commands to make them cancelable as well.