Skip to content

Prompts fixes #5946

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Jun 3, 2025
Merged

Prompts fixes #5946

merged 9 commits into from
Jun 3, 2025

Conversation

RomneyDa
Copy link
Collaborator

@RomneyDa RomneyDa commented Jun 2, 2025 •
edited
Loading

Description

Fixes #5667, #5363, #5245

  • Includes user input with prompt
  • Persists prompt content to chat history for non-MCP prompts (mcp are fully dynamically fetched) - still doesn't persist e.g. context items from @s within prompt files though, but this is almost always better than nothing
  • only allows one prompt at a time in UI
  • Removes hover click styling/opening empty virtual files for prompts with no content (includes MCP prompts)
  • Cleans up various duplicate code
  • Fixes nested prompt logic

Adds tests for prompt file rendering

@RomneyDa RomneyDa requested a review from a team as a code owner June 2, 2025 21:55
@RomneyDa RomneyDa requested review from tomasz-stefaniak and removed request for a team June 2, 2025 21:55
@cubic-dev-ai cubic-dev-ai
Copy link
Contributor

cubic-dev-ai bot commented Jun 2, 2025

Your cubic subscription is currently inactive. Please reactivate your subscription to receive AI reviews and use cubic.

@dosubot dosubot bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Jun 2, 2025
@netlify Netlify
Copy link

netlify bot commented Jun 2, 2025 •
edited
Loading

✅ Deploy Preview for continuedev canceled.

Name Link
🔨 Latest commit f8670c8
🔍 Latest deploy log https://app.netlify.com/projects/continuedev/deploys/683f721be0da080008a90b12

@RomneyDa RomneyDa mentioned this pull request Jun 2, 2025
Closed
3 tasks
@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. and removed size:S This PR changes 10-29 lines, ignoring generated files. labels Jun 3, 2025
@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. and removed size:L This PR changes 100-499 lines, ignoring generated files. labels Jun 3, 2025
This was referenced Jun 3, 2025
Closed
Closed
@RomneyDa RomneyDa changed the title Include user input in rendered prompt file Prompts fixes Jun 3, 2025
tomasz-stefaniak
tomasz-stefaniak requested changes Jun 3, 2025
View reviewed changes
Copy link
Collaborator

@tomasz-stefaniak tomasz-stefaniak left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you write tests for these changes? I'll be happy to approve this PR then 👌

@github-project-automation github-project-automation bot moved this from Todo to In Progress in Issues and PRs Jun 3, 2025
Patrick-Erichsen
Patrick-Erichsen previously approved these changes Jun 3, 2025
View reviewed changes
Copy link
Collaborator

@Patrick-Erichsen Patrick-Erichsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

few nitpicks but good to go toherwise 👍

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jun 3, 2025
@dosubot dosubot bot removed the size:M This PR changes 30-99 lines, ignoring generated files. label Jun 3, 2025
@dosubot dosubot bot added the size:L This PR changes 100-499 lines, ignoring generated files. label Jun 3, 2025
tomasz-stefaniak
tomasz-stefaniak approved these changes Jun 3, 2025
View reviewed changes
Copy link
Collaborator

@tomasz-stefaniak tomasz-stefaniak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating the tests! 💯

@RomneyDa RomneyDa merged commit 6d646ad into main Jun 3, 2025
36 checks passed
@RomneyDa RomneyDa deleted the dallin/broken-prompts branch June 3, 2025 22:34
@github-project-automation github-project-automation bot moved this from In Progress to Done in Issues and PRs Jun 3, 2025
@github-actions github-actions bot locked and limited conversation to collaborators Jun 3, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@tomasz-stefaniak tomasz-stefaniak tomasz-stefaniak approved these changes

@Patrick-Erichsen Patrick-Erichsen Patrick-Erichsen left review comments

Assignees
No one assigned
Labels
lgtm This PR has been approved by a maintainer size:L This PR changes 100-499 lines, ignoring generated files.
Projects
Issues and PRs
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Misleading UI/UX with Custom Prompts in Chat Interface
3 participants
@RomneyDa @tomasz-stefaniak @Patrick-Erichsen