fix: handle no parts returned from Gemini #5974
Merged
+8
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Your cubic subscription is currently inactive. Please reactivate your subscription to receive AI reviews and use cubic. |
✅ Deploy Preview for continuedev canceled.
|
dosubot
bot
added
the
size:S
This was referenced Jun 4, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes for #5776, #5572, #5912, #5762
Background:
Originally I avoided making this simple fix because it wasn't clear why the Gemini API would not send
partswithin content, since in their api speccontentwill always contain an arrayparts, but after quite a bit of tinkering it does seem to be a "bug" on the gemini side, and it only occurs when themaxTokenslimit is reached.An underlying issue is that we don't have maxTokens set for various gemini models in the hub or llm-info. Doing a follow up PR to update those.
UPDATE followup is here #5976