Include mcp server names in tool names #5991
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Your cubic subscription is currently inactive. Please reactivate your subscription to receive AI reviews and use cubic. |
✅ Deploy Preview for continuedev canceled.
|
dosubot
bot
added
the
size:M
RomneyDa
requested review from
Patrick-Erichsen
and removed request for
tomasz-stefaniak
|
@chezsmithy curious if anyone on your team has built rules/workflows around tools that would break with this change? |
Patrick-Erichsen
approved these changes
Jun 6, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prevents duplicate tool names from MCP servers
Has the downside of additional tokens for MCP server tools, and potential confusion if the mcp server name is very unrelated to the tool function.
Could look into other ways of making these unique but full mcp server name is fine for now. Models might do well with hashes/numbers
Could also only prepend mcp server names to duplicate tools - decided not to do this since not consistent and will cause tool policy thrashing