feat: use correct deployment for azure #6023
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Patrick-Erichsen
requested review from
tomasz-stefaniak
and removed request for
a team
|
Your cubic subscription is currently inactive. Please reactivate your subscription to receive AI reviews and use cubic. |
dosubot
bot
added
the
size:L
Patrick-Erichsen
commented
Jun 6, 2025
| // Default is `azure-openai` in docs, but previously was `azure` | ||
| if (this._isAzureOpenAI(config.env?.apiType)) { | ||
| if (!config.env?.deployment) { | ||
| throw new Error( |
There was a problem hiding this comment.
Because we call constructLlmApi even if we aren't using openai-adapters, and in our LLM Azure class we set azure-openai as the default, this will throw for existing users that don't have deployment set. But the current behavior n LLM OpenAI would be failing anyways without this
https://github.com/continuedev/continue/blob/pe/watsonx-vi/core/llm/llms/OpenAI.ts#L423-L428
return new URL(
`openai/deployments/${this.deployment}/embeddings?api-version=${this.apiVersion}`,
this.apiBase,
);
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.