Skip to content

Fix tool call name merging #6029

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 8, 2025
Merged

Fix tool call name merging #6029

merged 1 commit into from
Jun 8, 2025

Conversation

RomneyDa
Copy link
Collaborator

@RomneyDa RomneyDa commented Jun 8, 2025 •
edited
Loading

Fixes 2 bugs for tool call delta streaming

@RomneyDa RomneyDa requested a review from a team as a code owner June 8, 2025 06:08
@RomneyDa RomneyDa requested review from Patrick-Erichsen and removed request for a team June 8, 2025 06:08
@cubic-dev-ai cubic-dev-ai
Copy link

cubic-dev-ai bot commented Jun 8, 2025

Your cubic subscription is currently inactive. Please reactivate your subscription to receive AI reviews and use cubic.

@dosubot dosubot bot added the size:L This PR changes 100-499 lines, ignoring generated files. label Jun 8, 2025
@netlify Netlify
Copy link

netlify bot commented Jun 8, 2025 •
edited
Loading

✅ Deploy Preview for continuedev canceled.

Name Link
🔨 Latest commit 4a7393c
🔍 Latest deploy log https://app.netlify.com/projects/continuedev/deploys/684528d7eb91ed0008816863

sestinj
sestinj approved these changes Jun 8, 2025
View reviewed changes
Copy link
Contributor

@sestinj sestinj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice tests

@github-project-automation github-project-automation bot moved this from Todo to In Progress in Issues and PRs Jun 8, 2025
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jun 8, 2025
@sestinj sestinj merged commit 0dc5c42 into main Jun 8, 2025
37 checks passed
@sestinj sestinj deleted the dallin/tool-call-name-merge branch June 8, 2025 19:58
@github-project-automation github-project-automation bot moved this from In Progress to Done in Issues and PRs Jun 8, 2025
@github-actions github-actions bot locked and limited conversation to collaborators Jun 8, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sestinj sestinj sestinj approved these changes

@Patrick-Erichsen Patrick-Erichsen Awaiting requested review from Patrick-Erichsen Patrick-Erichsen is a code owner automatically assigned from continuedev/continue-code-reviewers

Assignees
No one assigned
Labels
lgtm This PR has been approved by a maintainer size:L This PR changes 100-499 lines, ignoring generated files.
Projects
Issues and PRs
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@RomneyDa @sestinj