Skip to content

fix: Fix the issue where the chunk index might be duplicated #6037

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 23, 2025

Conversation

jacob-lcs
Copy link
Contributor

Description

This pull request includes a small change to the chunkDocument function in core/indexing/chunk/chunk.ts. The change simplifies the incrementation of the index variable by directly incrementing it within the object assignment. Fix the issue where the chunk index might be duplicated.

Checklist

  • I've read the contributing guide
  • The relevant docs, if any, have been updated or created
  • The relevant tests, if any, have been updated or created

Screenshots

[ For visual changes, include screenshots. Screen recordings are particularly helpful, and appreciated! ]

Tests

[ What tests were added or updated to ensure the changes work as expected? ]

@jacob-lcs jacob-lcs requested a review from a team as a code owner June 9, 2025 03:05
@jacob-lcs jacob-lcs requested review from tomasz-stefaniak and removed request for a team June 9, 2025 03:05
Copy link

cubic-dev-ai bot commented Jun 9, 2025

Your cubic subscription is currently inactive. Please reactivate your subscription to receive AI reviews and use cubic.

@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Jun 9, 2025
Copy link

github-actions bot commented Jun 9, 2025

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

Copy link

netlify bot commented Jun 9, 2025

👷 Deploy request for continuedev pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit fa7bc17

@jacob-lcs
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

Copy link

recurseml bot commented Jun 13, 2025

✨ No issues found! Your code is sparkling clean! ✨

sestinj
sestinj previously approved these changes Jun 21, 2025
@github-project-automation github-project-automation bot moved this from Todo to In Progress in Issues and PRs Jun 21, 2025
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jun 21, 2025
@jacob-lcs
Copy link
Contributor Author

@sestinj I've updated the code, all CI checks have passed. Please take another look when you have time. If everything looks good, it can be merged. :)

@sestinj sestinj merged commit 85c53d2 into continuedev:main Jun 23, 2025
31 checks passed
@github-project-automation github-project-automation bot moved this from In Progress to Done in Issues and PRs Jun 23, 2025
@github-actions github-actions bot locked and limited conversation to collaborators Jun 23, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm This PR has been approved by a maintainer size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants