Skip to content

ignore running tests inside dist directory #6057

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 10, 2025

Conversation

jpoly1219
Copy link
Collaborator

Description

Many of the previous merges into main that touched packages/config-yaml failed to get released because our test suite was running tests inside dist. This PR safely removes them and maintains tests on src.

Checklist

  • [*] I've read the contributing guide
  • [*] The relevant docs, if any, have been updated or created
  • [*] The relevant tests, if any, have been updated or created

Screenshots

[ For visual changes, include screenshots. Screen recordings are particularly helpful, and appreciated! ]

Tests

[ What tests were added or updated to ensure the changes work as expected? ]

@jpoly1219 jpoly1219 requested a review from a team as a code owner June 10, 2025 00:15
@jpoly1219 jpoly1219 requested review from tomasz-stefaniak and removed request for a team June 10, 2025 00:15
Copy link

cubic-dev-ai bot commented Jun 10, 2025

Your cubic subscription is currently inactive. Please reactivate your subscription to receive AI reviews and use cubic.

Copy link

netlify bot commented Jun 10, 2025

Deploy Preview for continuedev canceled.

Name Link
🔨 Latest commit 449275c
🔍 Latest deploy log https://app.netlify.com/projects/continuedev/deploys/6847790b342bbb0008b54366

@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Jun 10, 2025
@jpoly1219 jpoly1219 requested review from RomneyDa and Patrick-Erichsen and removed request for tomasz-stefaniak June 10, 2025 00:17
@github-project-automation github-project-automation bot moved this from Todo to In Progress in Issues and PRs Jun 10, 2025
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jun 10, 2025
@Patrick-Erichsen Patrick-Erichsen merged commit 2980b96 into main Jun 10, 2025
66 of 68 checks passed
@Patrick-Erichsen Patrick-Erichsen deleted the jacob/bug/ignore-dist-tests branch June 10, 2025 19:00
@github-project-automation github-project-automation bot moved this from In Progress to Done in Issues and PRs Jun 10, 2025
@github-actions github-actions bot locked and limited conversation to collaborators Jun 10, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm This PR has been approved by a maintainer size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants