Skip to content

fix: apply notch filename trunaction #6058

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 10, 2025
Merged

fix: apply notch filename trunaction #6058

merged 3 commits into from
Jun 10, 2025

Conversation

Patrick-Erichsen
Copy link
Collaborator

@Patrick-Erichsen Patrick-Erichsen commented Jun 10, 2025 •
edited
Loading

Description

  • Fixes overflow on apply notch by hiding the Accept/Reject text on xs screens
  • Hides diff text on md screens and below for apply actions in toolbar

Closes CON-2134

Screenshots

Screenshot 2025-06-09 at 6 15 12 PM Screenshot 2025-06-09 at 6 22 03 PM

@cubic-dev-ai cubic-dev-ai
Copy link

cubic-dev-ai bot commented Jun 10, 2025

Your cubic subscription is currently inactive. Please reactivate your subscription to receive AI reviews and use cubic.

@Patrick-Erichsen Patrick-Erichsen marked this pull request as ready for review June 10, 2025 01:15
@Patrick-Erichsen Patrick-Erichsen requested a review from a team as a code owner June 10, 2025 01:15
@netlify Netlify
Copy link

netlify bot commented Jun 10, 2025 •
edited
Loading

✅ Deploy Preview for continuedev canceled.

Name Link
🔨 Latest commit cce5227
🔍 Latest deploy log https://app.netlify.com/projects/continuedev/deploys/68478926c9376e00084996ec

@Patrick-Erichsen Patrick-Erichsen requested review from RomneyDa and removed request for a team June 10, 2025 01:15
@dosubot dosubot bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Jun 10, 2025
@Patrick-Erichsen
Copy link
Collaborator Author

My other thoughts was that on xs screens and below we could hide the copy/insert buttons when applying, but this was a much easier fix

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jun 10, 2025
@github-project-automation github-project-automation bot moved this from Todo to In Progress in Issues and PRs Jun 10, 2025
@Patrick-Erichsen Patrick-Erichsen merged commit d0457e6 into main Jun 10, 2025
65 of 67 checks passed
@Patrick-Erichsen Patrick-Erichsen deleted the pe/apply-notch-fix branch June 10, 2025 17:36
@github-project-automation github-project-automation bot moved this from In Progress to Done in Issues and PRs Jun 10, 2025
@github-actions github-actions bot locked and limited conversation to collaborators Jun 10, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@RomneyDa RomneyDa RomneyDa approved these changes

Assignees
No one assigned
Labels
lgtm This PR has been approved by a maintainer size:S This PR changes 10-29 lines, ignoring generated files.
Projects
Issues and PRs
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Patrick-Erichsen @RomneyDa