Skip to content

chore: migrate core (commands, control-plane, data, diff) tests to vitest #6091

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jun 23, 2025

Conversation

uinstinct
Copy link
Contributor

Description

As part of our migration of tests inside core from jest to vitest, this PR:

  • migrates the tests in the commands directory.

related to CON-2030

requires #6063 to be merged first because it lays the requirements for vitest

Checklist

  • [] I've read the contributing guide
  • [] The relevant docs, if any, have been updated or created
  • [] The relevant tests, if any, have been updated or created

Screenshots

[ For visual changes, include screenshots. Screen recordings are particularly helpful, and appreciated! ]

Tests

[ What tests were added or updated to ensure the changes work as expected? ]

@uinstinct uinstinct requested a review from a team as a code owner June 12, 2025 12:23
@uinstinct uinstinct requested review from sestinj and removed request for a team June 12, 2025 12:23
Copy link

cubic-dev-ai bot commented Jun 12, 2025

Your cubic subscription is currently inactive. Please reactivate your subscription to receive AI reviews and use cubic.

Copy link

netlify bot commented Jun 12, 2025

👷 Deploy request for continuedev pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit 2574a8b

@dosubot dosubot bot added the size:L This PR changes 100-499 lines, ignoring generated files. label Jun 12, 2025
@uinstinct uinstinct changed the title Core vitest/command chore: migrate core (commands) tests to vitest Jun 12, 2025
@uinstinct uinstinct marked this pull request as draft June 12, 2025 12:24
@uinstinct uinstinct force-pushed the core-vitest/command branch from 8b59f58 to bb61947 Compare June 12, 2025 12:33
@uinstinct uinstinct force-pushed the core-vitest/command branch from bb61947 to 498e907 Compare June 13, 2025 13:54
@uinstinct uinstinct changed the title chore: migrate core (commands) tests to vitest chore: migrate core (commands, control-plane, data, diff) tests to vitest Jun 13, 2025
Copy link

recurseml bot commented Jun 13, 2025

⚠️ Only 5 files will be analyzed due to processing limits.

Copy link

recurseml bot commented Jun 13, 2025

✨ No issues found! Your code is sparkling clean! ✨

@uinstinct uinstinct marked this pull request as ready for review June 23, 2025 13:12
@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. and removed size:L This PR changes 100-499 lines, ignoring generated files. labels Jun 23, 2025
Copy link
Contributor

@sestinj sestinj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, and we can finish more tests later as needed

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jun 23, 2025
@github-project-automation github-project-automation bot moved this from Todo to In Progress in Issues and PRs Jun 23, 2025
@sestinj sestinj merged commit 9308a5a into continuedev:main Jun 23, 2025
32 checks passed
@github-project-automation github-project-automation bot moved this from In Progress to Done in Issues and PRs Jun 23, 2025
@github-actions github-actions bot locked and limited conversation to collaborators Jun 23, 2025
@uinstinct uinstinct deleted the core-vitest/command branch June 23, 2025 18:30
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm This PR has been approved by a maintainer size:M This PR changes 30-99 lines, ignoring generated files.
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants