feat: move rule parsing to config-yaml
#6138
Conversation
✅ Deploy Preview for continuedev canceled.
|
|
|
![recurseml[bot]](https://avatars.githubusercontent.com/in/1054195?s=60&v=4){kind=small}
|
😱 Found 2 issues. Time to roll up your sleeves! 😱 |
dosubot
bot
added
the
size:XL
| @@ -1,10 +1,17 @@ | |||
| { | |||
| "name": "@continuedev/config-yaml", | |||
| "version": "1.0.88", | |||
| "version": "1.0.92", | |||
There was a problem hiding this comment.
reminder to publish this new version once we merge
| "exports": { | ||
| ".": { | ||
| "browser": "./dist/browser.js", | ||
| "node": "./dist/index.js", | ||
| "default": "./dist/index.js" | ||
| } | ||
| }, |
There was a problem hiding this comment.
I had to add this because I updated unrollAssistant to include logic from our new config-yaml/markdown folder. unrollAssistant is included in registryClient, which uses node APIs, so we needed a separate entrypoint for browser envs
There was a problem hiding this comment.
nice! This is something I didn't know about, and had needed this before
| parsedYaml = { | ||
| name: rule.name, | ||
| version: "1.0.0", | ||
| rules: [rule], | ||
| }; |
There was a problem hiding this comment.
We map markdown rules to yaml rules for now
| // TODO: What should be required? | ||
| export const rulesJsonSchema = z.object({ | ||
| name: z.string(), | ||
| version: z.string(), | ||
| author: z.string().optional(), | ||
| license: z.string().optional(), | ||
| rules: z.record(z.string(), z.string()).optional(), | ||
| }); | ||
|
|
There was a problem hiding this comment.
I'm not sure if this is where we want to define this, but I'd like to have the types available for use on the hub
There was a problem hiding this comment.
So far I'm defining it in a JSON schema here: https://github.com/continuedev/rules-cli/blob/main/internal/validation/schema/rules-schema.json because we'll need it for both CLI and other things. Might not be necessary to define this here. Just making a note to myself here
dosubot
bot
added
size:L
dosubot
bot
added
size:XL
…ect a header automatically)
Consolidates rule parsing functionality by moving it from the core config module to the shared
config-yamlpackage.