Skip to content

Fix bug caused by empty config.json #6149

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 17, 2025
Merged

Conversation

sestinj
Copy link
Contributor

@sestinj sestinj commented Jun 16, 2025

Description

Users who had an empty or invalid config.json were seeing an error loading the config because the migration was failing, but this isn't a critical error so it just needs to be logged instead of blocking all usage

Checklist

  • I've read the contributing guide
  • The relevant docs, if any, have been updated or created
  • The relevant tests, if any, have been updated or created

@sestinj sestinj requested a review from a team as a code owner June 16, 2025 20:34
@sestinj sestinj requested review from Patrick-Erichsen and removed request for a team June 16, 2025 20:34
Copy link

netlify bot commented Jun 16, 2025

Deploy Preview for continuedev failed. Why did it fail? →

Name Link
🔨 Latest commit dd81368
🔍 Latest deploy log https://app.netlify.com/projects/continuedev/deploys/68507fde1147670008267e11

@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Jun 16, 2025
Copy link

recurseml bot commented Jun 16, 2025

✨ No issues found! Your code is sparkling clean! ✨

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jun 17, 2025
@github-project-automation github-project-automation bot moved this from Todo to In Progress in Issues and PRs Jun 17, 2025
@Patrick-Erichsen Patrick-Erichsen merged commit 3237e3f into main Jun 17, 2025
35 of 39 checks passed
@Patrick-Erichsen Patrick-Erichsen deleted the nate/migration-no-throw branch June 17, 2025 18:17
@github-project-automation github-project-automation bot moved this from In Progress to Done in Issues and PRs Jun 17, 2025
@github-actions github-actions bot locked and limited conversation to collaborators Jun 17, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm This PR has been approved by a maintainer size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants