Handle empty query by sending "null" instead of empty string in MCP context provider #6225
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for continuedev canceled.
|
dosubot
bot
added
the
size:XS
![recurseml[bot]](https://avatars.githubusercontent.com/in/1054195?s=60&v=4){kind=small}
| @@ -56,7 +56,9 @@ class MCPContextProvider extends BaseContextProvider { | |||
| private insertInputToUriTemplate(uri: string, query: string): string { | |||
| const TEMPLATE_VAR = "query"; | |||
| if (uri.includes(`{${TEMPLATE_VAR}}`)) { | |||
| return uri.replace(`{${TEMPLATE_VAR}}`, encodeURIComponent(query)); | |||
| // Sending an empty string will result in an error, so we instead send "null" | |||
| const queryOrNull = query.trim() === "" ? "null" : query; | |||
There was a problem hiding this comment.
This line assumes query is a non-null string and calls trim() without any type checking. Since this method is called with extras.fullInput which could be undefined, this could cause a runtime error. The code should add a null check before using trim(), e.g., const queryOrNull = (query?.trim() ?? "") === "" ? "null" : query;
React with 👍 to tell me that this comment was useful, or 👎 if not (and I'll stop posting more comments like this in the future)
|
😱 Found 1 issue. Time to roll up your sleeves! 😱 |
Patrick-Erichsen
approved these changes
Jun 23, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Empty query was causing "resource not found" even though the user should be allowed to enter nothing in the input box. There was no way of handling the empty string with current MCP server frameworks