Skip to content

Fix azure opena ai query params #6227

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 20, 2025
Merged

Conversation

RomneyDa
Copy link
Collaborator

Description

The openAI constructor takes baseUrl and query params separately
We were passing query params in baseUrl, which led to Urls like:
https://azure-example/openai/deployments/example-deployment?api-version=2024-12-01-preview/chat/completions"

This fixes that by sending the params to defaultQuery

@RomneyDa RomneyDa requested a review from a team as a code owner June 20, 2025 20:45
@RomneyDa RomneyDa requested review from tomasz-stefaniak and removed request for a team June 20, 2025 20:45
Copy link

netlify bot commented Jun 20, 2025

Deploy Preview for continuedev canceled.

Name Link
🔨 Latest commit e235a30
🔍 Latest deploy log https://app.netlify.com/projects/continuedev/deploys/6855c85cdf45f60008192115

@dosubot dosubot bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Jun 20, 2025
Copy link

recurseml bot commented Jun 20, 2025

✨ No issues found! Your code is sparkling clean! ✨

@RomneyDa RomneyDa removed the request for review from tomasz-stefaniak June 20, 2025 20:49
Copy link
Collaborator

@Patrick-Erichsen Patrick-Erichsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice find 👌

@github-project-automation github-project-automation bot moved this from Todo to In Progress in Issues and PRs Jun 20, 2025
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jun 20, 2025
@Patrick-Erichsen Patrick-Erichsen merged commit 60f076f into main Jun 20, 2025
39 checks passed
@Patrick-Erichsen Patrick-Erichsen deleted the dallin/azure-query-params branch June 20, 2025 21:33
@github-project-automation github-project-automation bot moved this from In Progress to Done in Issues and PRs Jun 20, 2025
@github-actions github-actions bot locked and limited conversation to collaborators Jun 20, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm This PR has been approved by a maintainer size:S This PR changes 10-29 lines, ignoring generated files.
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants