Skip to content

feat: create AssistantAndOrgListbox #6247

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jun 23, 2025
Merged

Conversation

Patrick-Erichsen
Copy link
Collaborator

@Patrick-Erichsen Patrick-Erichsen commented Jun 22, 2025

Description

Most of the file changes here are due to me creating a new AssistantAndOrgListbox component that breaks out all the subcomponents from the old AssistantSelect. No new logic, just UI changes.

Closes CON-2156

Signed in

Screenshot 2025-06-22 at 11 05 04 AM

Signed out

Screenshot 2025-06-22 at 11 39 44 AM

@Patrick-Erichsen Patrick-Erichsen requested a review from a team as a code owner June 22, 2025 18:25
@Patrick-Erichsen Patrick-Erichsen requested review from sestinj and removed request for a team June 22, 2025 18:25
Copy link

netlify bot commented Jun 22, 2025

Deploy Preview for continuedev ready!

Name Link
🔨 Latest commit 393bf08
🔍 Latest deploy log https://app.netlify.com/projects/continuedev/deploys/685999dcf61b6c0008def4a1
😎 Deploy Preview https://deploy-preview-6247--continuedev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@dosubot dosubot bot added the size:XL This PR changes 500-999 lines, ignoring generated files. label Jun 22, 2025
Copy link

recurseml bot commented Jun 22, 2025

⚠️ Only 5 files will be analyzed due to processing limits.

import { useAuth } from "../../context/Auth";
import { IdeMessengerContext } from "../../context/IdeMessenger";
import { useAppDispatch, useAppSelector } from "../../redux/hooks";
import {
selectCurrentOrg,
setSelectedOrgId,
} from "../../redux/slices/profilesSlice";
import {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Incorrect import path change that will cause a module not found error. The import path was changed from '../../components/ui/Listbox' to '../ui/Listbox', but based on the project structure, this new path is invalid. Going up one level from the current file location (AssistantAndOrgListbox) leads to the components directory, but there's no 'ui' directory directly under components. This will cause a runtime error as the Listbox components won't be found. The original path should be maintained or the correct path should be used.


React with 👍 to tell me that this comment was useful, or 👎 if not (and I'll stop posting more comments like this in the future)

Copy link

recurseml bot commented Jun 22, 2025

😱 Found 1 issue. Time to roll up your sleeves! 😱

@dosubot dosubot bot added size:XXL This PR changes 1000+ lines, ignoring generated files. and removed size:XL This PR changes 500-999 lines, ignoring generated files. labels Jun 22, 2025
Copy link
Contributor

@sestinj sestinj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of changes. Here, we should hide the "Organization" title and the dropdown if the user only has the Personal org. Instead, we can show either "Signed in as " or "Signed out".

Screenshot 2025-06-23 at 10 22 07 AM

And then I think we should add icons to the "New Assistant" and "Sign in" buttons (+ and box with arrow or person icons potentially)

@github-project-automation github-project-automation bot moved this from Todo to In Progress in Issues and PRs Jun 23, 2025
@Patrick-Erichsen
Copy link
Collaborator Author

Patrick-Erichsen commented Jun 23, 2025

Here's what will show if the following is true. I decided not to add the "Signed out" since I felt it was clear from the "Log in" option that we already render.

 const shouldRenderOrgInfo =
    session && organizations.length > 1 && !isOnPremSession(session);
Screenshot 2025-06-23 at 11 15 27 AM

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jun 23, 2025
@sestinj sestinj merged commit ca6e400 into main Jun 23, 2025
37 checks passed
@sestinj sestinj deleted the pe/assistant-and-org-listbox branch June 23, 2025 19:04
@github-project-automation github-project-automation bot moved this from In Progress to Done in Issues and PRs Jun 23, 2025
@github-actions github-actions bot locked and limited conversation to collaborators Jun 23, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm This PR has been approved by a maintainer size:XXL This PR changes 1000+ lines, ignoring generated files.
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants