-
Notifications
You must be signed in to change notification settings - Fork 3.1k
feat: create AssistantAndOrgListbox
#6247
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview for continuedev ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
import { useAuth } from "../../context/Auth"; | ||
import { IdeMessengerContext } from "../../context/IdeMessenger"; | ||
import { useAppDispatch, useAppSelector } from "../../redux/hooks"; | ||
import { | ||
selectCurrentOrg, | ||
setSelectedOrgId, | ||
} from "../../redux/slices/profilesSlice"; | ||
import { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Incorrect import path change that will cause a module not found error. The import path was changed from '../../components/ui/Listbox' to '../ui/Listbox', but based on the project structure, this new path is invalid. Going up one level from the current file location (AssistantAndOrgListbox) leads to the components directory, but there's no 'ui' directory directly under components. This will cause a runtime error as the Listbox components won't be found. The original path should be maintained or the correct path should be used.
React with 👍 to tell me that this comment was useful, or 👎 if not (and I'll stop posting more comments like this in the future)
😱 Found 1 issue. Time to roll up your sleeves! 😱 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couple of changes. Here, we should hide the "Organization" title and the dropdown if the user only has the Personal org. Instead, we can show either "Signed in as " or "Signed out".

And then I think we should add icons to the "New Assistant" and "Sign in" buttons (+ and box with arrow or person icons potentially)
Description
Most of the file changes here are due to me creating a new
AssistantAndOrgListbox
component that breaks out all the subcomponents from the oldAssistantSelect
. No new logic, just UI changes.Closes CON-2156
Signed in
Signed out