Skip to content

fix: use last 2 parts of file uri for rule names #6248

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 23, 2025

Conversation

Patrick-Erichsen
Copy link
Collaborator

Description

Current behavior is that the entire file URI is shown as rule name, which is more/less useless since we truncate the display, and the beginning of all file URIs for a workspace will always be the same.

This PR changes behavior to instead be the last 2 parts of the URI. I think ideally we'd somehow keep the full URI and let the callee decide how to render the name based on this, but for now this is 1% better.

@Patrick-Erichsen Patrick-Erichsen requested a review from a team as a code owner June 22, 2025 19:08
@Patrick-Erichsen Patrick-Erichsen requested review from sestinj and removed request for a team June 22, 2025 19:08
Copy link

netlify bot commented Jun 22, 2025

Deploy Preview for continuedev canceled.

Name Link
🔨 Latest commit 94113e0
🔍 Latest deploy log https://app.netlify.com/projects/continuedev/deploys/685854c9a3bc3a0008c271c7

@dosubot dosubot bot added the size:L This PR changes 100-499 lines, ignoring generated files. label Jun 22, 2025
Copy link

recurseml bot commented Jun 22, 2025

✨ No issues found! Your code is sparkling clean! ✨

Copy link
Contributor

@sestinj sestinj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

makes sense, good tests

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jun 23, 2025
@github-project-automation github-project-automation bot moved this from Todo to In Progress in Issues and PRs Jun 23, 2025
@sestinj sestinj merged commit 27124fc into main Jun 23, 2025
96 of 101 checks passed
@sestinj sestinj deleted the pe/local-rule-filepath-bugfix branch June 23, 2025 17:25
@github-project-automation github-project-automation bot moved this from In Progress to Done in Issues and PRs Jun 23, 2025
@github-actions github-actions bot locked and limited conversation to collaborators Jun 23, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm This PR has been approved by a maintainer size:L This PR changes 100-499 lines, ignoring generated files.
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants