-
Notifications
You must be signed in to change notification settings - Fork 3.1k
add enable reasoning button #6254
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
👷 Deploy request for continuedev pending review.Visit the deploys page to approve it
|
@@ -86,6 +87,13 @@ function ParallelListeners() { | |||
setLocalStorage("fontSize", configResult.config.ui.fontSize); | |||
document.body.style.fontSize = `${configResult.config.ui.fontSize}px`; | |||
} | |||
|
|||
if ( | |||
configResult.config?.selectedModelByRole.chat?.completionOptions |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unsafe property access chain: When config is optional (accessed with ?.), selectedModelByRole is accessed without optional chaining. This can cause runtime errors if config exists but selectedModelByRole is undefined. Based on codebase patterns, selectedModelByRole should be accessed with optional chaining when config is optional. Fix: Change to configResult.config?.selectedModelByRole?.chat?.completionOptions
React with 👍 to tell me that this comment was useful, or 👎 if not (and I'll stop posting more comments like this in the future)
😱 Found 1 issue. Time to roll up your sleeves! 😱 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nicely done! No comments necessary, this will be a good experiment to see how users like it
Description
Show an enable reasoning button in the toolbar to force the model to use reasoning.
This is now only applicable for anthropic models.
hasReasoningEnabled
in config reducerParallelListeners
resolves CON-2296
Checklist
Screenshots
[ For visual changes, include screenshots. Screen recordings are particularly helpful, and appreciated! ]
feat.mp4
Tests
[ What tests were added or updated to ensure the changes work as expected? ]