fix: skip ripgrep if workspace is remote

[uinstinct]

Description

When workspace is remote, we want to avoid running ripgrep. This is because ripgrep will run locally instead of running the workspace server.

• when workspace is remote, use baseToolDefinitions excluding grepSearchTool
• add a new type IDE interface isWorkspaceRemote to detect if workspace is remote in vscode and intellij

resolves CON-2298

If it is possible to run os remote call from remote installed extension, we should be able to implement grep search for remote ides. corresponding issue in vscode: microsoft/vscode#252269

Checklist

• [] I've read the contributing guide
• [] The relevant docs, if any, have been updated or created
• [] The relevant tests, if any, have been updated or created

Screenshots

[ For visual changes, include screenshots. Screen recordings are particularly helpful, and appreciated! ]

before.mp4

after.mp4

Tests

[ What tests were added or updated to ensure the changes work as expected? ]

Replication

You can run a docker container for ssh into a remote host.
You can this dockerfile: https://gist.github.com/uinstinct/314da2b450f5440069bbce5ab14043d2

[netlify]

👷 Deploy request for continuedev pending review.

Visit the deploys page to approve it

Name	Link
🔨 Latest commit	5db1bef

[recurseml]

⚠️ Only 5 files will be analyzed due to processing limits.

[recurseml]

✨ No issues found! Your code is sparkling clean! ✨

[Patrick-Erichsen]

Great work, I'm going to save that dockerfile Gist for easier testing in the future! I've been spinning up an EC2 instance for SSH tests but that was way easier.

This worked for me, I just had a nitpick on some of the logic and then we should be good to merge here.

[Patrick-Erichsen]

I think it would be a little more clear if we inverted the logic here/in the await ide.isWorkspaceRemote() call. Renaming baseToolDefinitions to remoteToolDefinitions forces us to always think in terms of remote or not which is more of an edge case

export const localOnlyToolDefinitions = [grepSearchTool]
export const baseToolDefinitions = [ ... ] // unchanged from before

...

 const continueConfig: ContinueConfig = {
    slashCommands: [],
    tools: [
      ...((await ide.isWorkspaceRemote())
        ? baseToolDefinitions
        : [...baseToolDefinitions, ...localOnlyToolDefinitions),
    ],

[Patrick-Erichsen]

Also, if it's possible to move the (await ide.isWorkspaceRemote()) ternary into a standalone fn in our core/tools folder I think that would be nice to keep the logic centralized. I anticipate that it will continue to get more complicated over time.

[Patrick-Erichsen]

One other thought 😅 let's throw a link to the upstream issue you opened on the vscode repo in a comment on the localOnlyToolDefinitions object. Then we can hopefully follow up and remove it in the future.

[uinstinct]

makes sense. refactored to getToolsForIde inside core/tools/index.ts

[Patrick-Erichsen]

I didn't now we had remoteName logic already built out, neat

[Patrick-Erichsen]

Hmm another thought, maybe we put your Gist into the scripts folder? That would be nice to have on hand.

[uinstinct]

Hmm another thought, maybe we put your Gist into the scripts folder? That would be nice to have on hand.

yes agree. made a few changes and added it as a new script