perf: Avoid storing services as a field in long-lived components #6308
+44
−82
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
the
size:L
|
|
✅ Deploy Preview for continuedev canceled.
|
|
✨ No issues found! Your code is sparkling clean! ✨ Need help? Join our Discord for support! |
We should never acquire service instances prematurely or store them in fields for later use. This is considered as bad practice due to potential memory leaks. More details: https://plugins.jetbrains.com/docs/intellij/plugin-services.html#retrieving-a-service FYI there's a nice extension method for retrieving services like `project.service<MyService>` or `service<MyService>` for application-level services (like Continue settings). I've applied this everywhere.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Motivation: We should never acquire service instances prematurely or store them in fields for later use. This is considered as bad practice due to potential memory leaks. More details: https://plugins.jetbrains.com/docs/intellij/plugin-services.html#retrieving-a-service
FYI there's a nice extension method for retrieving services like
project.service<MyService>orservice<MyService>for application-level services (like Continue settings). I've applied this everywhere.This fix is somewhat related to #5819