Fix oversized non-emoji rgba glyphs #734
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
documentation
christianparpart
force-pushed
the
fix/oversized-rgba-glyphs
branch
3 times, most recently
from
b9069d9 to
8fed3e8
Compare
christianparpart
force-pushed
the
fix/oversized-rgba-glyphs
branch
from
29e5b27 to
8acc208
Compare
christianparpart
force-pushed
the
fix/oversized-rgba-glyphs
branch
from
8acc208 to
7ffae61
Compare
christianparpart
force-pushed
the
master
branch
2 times, most recently
from
1a1c769 to
b93a36e
Compare
christianparpart
force-pushed
the
fix/oversized-rgba-glyphs
branch
from
7ffae61 to
c624818
Compare
|
In general before landing this patch there should be a defence mechanism against corruption due to oversized glyphs in the texture atlas system first. |
christianparpart
force-pushed
the
fix/oversized-rgba-glyphs
branch
from
c624818 to
372feb0
Compare
github-actions
bot
removed
the
documentation
christianparpart
force-pushed
the
fix/oversized-rgba-glyphs
branch
5 times, most recently
from
a14d100 to
ceea58a
Compare
I've done that now as an "assert", because it's guarded earlier, and if something is leaking through, then it's a bug that should be reported and fixed rather than silently ignored. Oversized glyphs however should not be a problem now anyways (famous last words). :) |
christianparpart
force-pushed
the
fix/oversized-rgba-glyphs
branch
8 times, most recently
from
d21f61a to
a0766c2
Compare
christianparpart
force-pushed
the
fix/oversized-rgba-glyphs
branch
4 times, most recently
from
a90c6c1 to
eb399dc
Compare
… exceeding tile's width.
christianparpart
force-pushed
the
fix/oversized-rgba-glyphs
branch
from
eb399dc to
c6ca063
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #423 on oversized glyphs.