memcached-frontend is not used

[Olli73773]

Wenn I enable memcache-frontend in my values

...
memcached-frontend:
  enabled: true
...

The memcache is deployed but not used.
I think the -frontend.memcached.addresses arg is missing

$ kubectl -n cortex describe pods cortex-query-frontend-5bc659c46d-mnp7r
Name:         cortex-query-frontend-5bc659c46d-mnp7r
...
Containers:
  cortex:
...
    Args:
      -target=query-frontend
      -config.file=/etc/cortex/cortex.yaml
      -blocks-storage.bucket-store.index-cache.backend=memcached
      -blocks-storage.bucket-store.index-cache.memcached.addresses=dnssrvnoa+_memcache._tcp.cortex-memcached-blocks-index.cortex.svc:11211
      -blocks-storage.bucket-store.chunks-cache.backend=memcached
      -blocks-storage.bucket-store.chunks-cache.memcached.addresses=dns+cortex-memcached-blocks.cortex.svc:11211
      -blocks-storage.bucket-store.metadata-cache.backend=memcached
      -blocks-storage.bucket-store.metadata-cache.memcached.addresses=dns+cortex-memcached-blocks-metadata.cortex.svc:11211
    State:          Running
      Started:      Tue, 22 Jun 2021 09:13:48 +0200
...

I think it is caused by a missing include or wrong include in templates/query-frontend/query-frontend-dep.yaml (line 54)

...
            {{- include "cortex.memcached" . | nindent 12 }}
...

This should be

...
            {{- include "cortex.frontend-memcached" . | nindent 12 }}
...

[nschad]

🤦 🤦 🤦 🤦 🤦 🤦 🤦 🤦 🤦 🤦 🤦

Thank you!

Do you want to create an PR?

[Olli73773]

Yes will create a PR.