Upgrade memcached and add sa token mount value #142
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryanprobus
force-pushed
the
upgrade-memcached-chart
branch
3 times, most recently
from
64e9dc7 to
356c7bd
Compare
ryanprobus
changed the title
nschad
requested changes
Jun 6, 2021
|
@ryanprobus Also please document your Change in the CHANGELOG.md
|
|
If there is a better memcached chart we can go with, let's take a look at it. |
I wish...I think we just have to suck it up until maybe something like redis is supported or whatever |
ryanprobus
force-pushed
the
upgrade-memcached-chart
branch
from
356c7bd to
555eb5f
Compare
|
@ShuzZzle Sorry, was on vacation past couple weeks. Removed chart version bump, added to changelog and changed memcached upgrade from 5.5.1 to 5.13.0 (currently the newest published version). EDIT: And rebased again just now to fix changelog merge conflict. |
* Upgrades memcached helm chart from 5.5.1 to 5.13.0 which adds support for specifying service account association and creation * Adds service account value for whether to automount the token Signed-off-by: Ryan Probus <[email protected]>
ryanprobus
force-pushed
the
upgrade-memcached-chart
branch
from
555eb5f to
829deb5
Compare
nschad
approved these changes
Jun 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
for specifying service account association and creation
Signed-off-by: Ryan Probus [email protected]